Problem with id containing a period

[kiequoo]

When creating a jQuery object from a piece of html, if an id attribute within the HTML contains a period, this breaks the find command and it never returns a result. This is best seen in this example in jsFiddle:  http://jsfiddle.net/2gHqc/ - when run with jQuery 1.4.4 the alert displays 0, in previous versions of jQuery it returns 1.

[boushley]

And having a period in the id is valid according to the W3 "ID and NAME tokens must begin with a letter ([A-Za-z]) and may be followed by any number of letters, digits ([0-9]), hyphens ("-"), underscores ("_"), colons (":"), and periods (".")."  http://www.w3.org/TR/html401/types.html#type-name

[jitter]

The issue is a bit more complex, as in HTML 5 basically everything is allowed as ID token.

A possible start/idea for a fix could be what I tried on this  pull request.

Not sure if I catched all relevant characters in the regexp, please double check. I will update when necessary.

[addyosmani]

#7619 is a duplicate of this ticket.

[jitter]

(In #7620) Thanks for taking the time to contribute to the jQuery project by writing a bug report and providing a testcase!

 reduced test case

jQuery has sometimes issues when the id attribute contains meta characters. Here it is triggered as jQuery internally uses the present id attribute to speed up the search. Check on #7533 which (once fixed) should also fix this bug.

[anonymous]

Having a non escaped period (.) maybe valid for the HTML attribute value but *not* the CSS selector. QSA is correct when it chokes on the non-escaped IDs.  http://www.w3.org/TR/CSS21/syndata.html#value-def-identifier

Because jQuery is dynamically constructing selectors it bares the responsibility of escaping them in those instances.

[jitter]

Replying to anonymous:

QSA is correct when it chokes on the non-escaped IDs.

And nobody claims otherwise. That's why this ticket got accepted as valid and has a patch pending.

[jitter]

#7620 is a duplicate of this ticket.

[jitter]

#7634 is a duplicate of this ticket.

[jitter]

#7643 is a duplicate of this ticket.

[jitter]

#7661 is a duplicate of this ticket.

[jitter]

#7680 is a duplicate of this ticket.

[jitter]

new  pull request with the solution suggested by John Resig

[john]

Landed.

[jitter]

#7740 is a duplicate of this ticket.

[jitter]

#7776 is a duplicate of this ticket.

[jitter]

#7807 is a duplicate of this ticket.

[ajpiano]

#7820 is a duplicate of this ticket.

[ajpiano]

#7829 is a duplicate of this ticket.

[anonymous]

Replying to ajpiano:

#7829 is a duplicate of this ticket.

#7829 is not a duplicate, please see the demo here:  http://jsfiddle.net/QYUPQ/1/

You can compare it to:  http://jsfiddle.net/QYUPQ/

[ajpiano]

#7873 is a duplicate of this ticket.

[jitter]

Move fixed tickets to appropriate milestone

[jitter]

#8021 is a duplicate of this ticket.