#9719 closed bug (fixed)

Opened July 01, 2011 04:36AM UTC

Closed August 25, 2011 07:45PM UTC

Last modified March 13, 2012 01:56PM UTC

removeAttr('disabled') doesn't change input's color on IE6,JQ 1.6.2

Reported by:	firstrose@gmail.com	Owned by:	timmywil
Priority:	high	Milestone:	1.6.3
Component:	attributes	Version:	1.6.2
Keywords:		Cc:
Blocked by:		Blocking:

Description

Using following code on IE6:

    <input id="FSC_btnSave" type="button" value="Save" onclick="alert('clickable');"
        disabled="disabled" />
    <input id="FSC_btnClose" type="button" onclick="Test();" value="Close" />

        function Test()
        {
            $('#FSC_btnSave').removeAttr('disabled');
            //$('#FSC_btnSave').attr('disabled',false);
        }

JQ1.6.2 only makes the button clickable, looking still gray.

But 1.6.1 works fine.

Attachments (0)

Change History (21)

Changed July 01, 2011 02:16PM UTC by timmywil comment:1

component:	unfiled → attributes
owner:	→ firstrose@gmail.com
priority:	undecided → low
status:	new → pending

Thanks for taking the time to contribute to the jQuery project! Please provide a reduced test case on http://jsfiddle.net that reproduces the issue experienced to help us assess your ticket.

Additionally, test against the jQuery (edge) version to ensure the issue still exists.

Changed July 05, 2011 11:09AM UTC by anonymous comment:2

We experience the same problem on IE7. I saved a reduced test case on jsfiddle:

http://jsfiddle.net/rpXwF/

The button is clickable, but visually it remains disabled. On jQuery 1.6.1 it works as expected.

Changed July 05, 2011 01:30PM UTC by timmywil comment:3

owner:	firstrose@gmail.com → timmywil
status:	pending → assigned

Confirmed, not sure the difference. I'll take a look.

Changed July 05, 2011 01:30PM UTC by timmywil comment:4

priority:	low → high

Changed July 05, 2011 03:09PM UTC by timmywil comment:5

I have no idea how, but this commit changed the behavior cf702496ee28830f3488ed3f1c3940cfbb2dfa8f

Either way, the hook is set so I don't see how this could change anything except some kind of accessing magic that cause IE to repaint.

Changed July 05, 2011 03:10PM UTC by timmywil comment:6

For me: http://jsfiddle.net/timmywil/q4s7a/

Changed July 12, 2011 06:25PM UTC by rwaldron comment:7

resolution:	→ worksforme
status:	assigned → closed

This will fix your issue:

$("#Save").prop("disabled", false);

Changed July 20, 2011 09:33PM UTC by anonymous comment:8

Does this mean that the issue with removeAttr("disabled") will not be fixed for 1.6.3? In fact, you can see the problem when using IE to view the removeAttr() documentation example.

Replying to [comment:7 rwaldron]:

This will fix your issue:
> $("#Save").prop("disabled", false);
> 

Changed July 20, 2011 09:38PM UTC by timmywil comment:9

resolution:	worksforme
status:	closed → reopened

This should probably stay open since we still want to support this in attr/removeAttr, even though prop is the preferred usage. I did narrow it down to the argument check causing a repaint, so that is really weird, but I'll assign this to myself and play with it.

Changed July 20, 2011 09:38PM UTC by timmywil comment:10

status:	reopened → assigned

Changed July 26, 2011 12:59AM UTC by anonymous comment:11

FYI: IE 8 has the same problem above.

Changed August 08, 2011 07:47PM UTC by anonymous comment:12

I've test with: IE 6 SP1, IE 6 SP3, IE 7 IE 8 and IE9. I have the same problem above.

I try

.prop("disabled", false);
.prop("readonly", false);

but not work.

Changed August 11, 2011 09:48PM UTC by jquery@kenman.net comment:13

Changed August 12, 2011 01:35PM UTC by timmywil comment:14

#9952 is a duplicate of this ticket.

Changed August 12, 2011 01:36PM UTC by timmywil comment:15

#10034 is a duplicate of this ticket.

Changed August 12, 2011 07:16PM UTC by jquery@kenman.net comment:16

Sorry to reference the wrong ticket earlier; I meant to reference #9952. Thanks!

Changed August 12, 2011 07:26PM UTC by jquery@kenman.net comment:17

More dupes I believe: #9812, #9927

Changed August 14, 2011 07:20PM UTC by timmywil comment:18

#10046 is a duplicate of this ticket.

Changed August 18, 2011 02:25PM UTC by dmethvin comment:19

#10083 is a duplicate of this ticket.

Changed August 25, 2011 07:45PM UTC by timmywil comment:20

milestone:	1.next → 1.6.3
resolution:	→ fixed
status:	assigned → closed

Fixed in this commit: https://github.com/jquery/jquery/commit/d723942b274e3e48dac82ebde11906a4cb349415

Changed September 27, 2011 01:04PM UTC by dmethvin comment:21

#10351 is a duplicate of this ticket.

Side navigation