attr() fails for non DOM element nodes

[jitter]

With the changes for 1.4.3 a regression was introduced which prevented the use of attr() on anything but DOM element nodes (where nodeType is 1) see #7451 and the fix in 1.4.4 ​commit #a64dc0

But now attr(name) and attr(name, value) fails in various circumstances.

​test case switch from version 1.4.2 to 1.4.3 to 1.4.4 to see how the behavior changed from working, to partially working to breaking with exceptions.

[jitter]

​pull request

There is much noise from whitespace changes use diff -w to see the what's really going on

[Rick Waldron]

Addy, I'm gonna change this to a blocker until we get a consensus on the behaviour regression.

[Rick Waldron]

#7497 is a duplicate of this ticket.

[SlexAxton]

#7505 is a duplicate of this ticket.

[addyosmani]

#7517 is a duplicate of this ticket.

[jitter]

Why pending?

[Rick Waldron]

@jitter - weird, I don't remember doing that at all... But check this out: I DID post this... 28 hours ago: ​http://bugs.jquery.com/ticket/7582

[snover]

​pull request

[jitter]

#7591 is a duplicate of this ticket.

[Rick Waldron]

#7605 is a duplicate of this ticket.

[Rick Waldron]

#7665 is a duplicate of this ticket.

[jitter]

#7503 is a duplicate of this ticket.

[john]

Landed

[jitter]

Move fixed tickets to appropriate milestone

[shepik]

The bug reappeared again 1.5.2: everything ok 1.6.0: Getting attribute foo failed for node of type plainjsobject elem.getAttribute is not a function

​http://jsfiddle.net/A9auC/22/

[Timmy Willison]

As the docs for ​http://api.jquery.com/attr states, do not use attr on the document or plain objects. ​http://api.jquery.com/prop will work instead, but for the document I suggest attaching data with ​http://api.jquery.com/data unless property manipulation is necessary.