Skip to main content

Bug Tracker

Side navigation

#7665 closed bug (worksforme)

Opened November 30, 2010 09:15PM UTC

Closed December 09, 2010 07:10PM UTC

Last modified January 31, 2011 05:55PM UTC

$.fn.data broken in jQuery 1.4.4 (related to pulling HTML5 data- attributes)

Reported by: cobexer Owned by: cobexer
Priority: high Milestone: 1.5
Component: data Version: 1.5
Keywords: Cc:
Blocked by: Blocking:
Description

in jQuery 1.4.4 calling $(window).data() results in an error

same for document(and everything that has no attributes property)

Attachments (0)
Change History (13)

Changed November 30, 2010 09:35PM UTC by rwaldron comment:1

owner: → cobexer
status: newpending

Thanks for taking the time to contribute to the jQuery project! Please provide a reduced jsFiddle test case to help us assess your ticket!

Additionally, test against the latest jQuery release AND the jQuery 0 GIT version to ensure the issue still exists. Be Excellent to eachother!

Changed November 30, 2010 09:38PM UTC by jitter comment:2

Duplicate of #7500?

Changed November 30, 2010 09:52PM UTC by rwaldron comment:3

resolution: → duplicate
status: pendingclosed

It sure is. Thanks Jitter

http://jsfiddle.net/rwaldron/tGHc5/3/

Changed November 30, 2010 09:52PM UTC by rwaldron comment:4

Duplicate of #7500.

Changed November 30, 2010 10:12PM UTC by cobexer comment:5

I now added https://github.com/jquery/jquery/pull/115 to fix this, then realized it was closed as duplicate however the other tickets (and the linked commits) do not seem to cover this.

please have a look at the changes i made

Changed November 30, 2010 10:25PM UTC by jitter comment:6

resolution: duplicate
status: closedreopened

Changed November 30, 2010 10:25PM UTC by jitter comment:7

component: unfileddata
milestone: 1.next1.4.5
priority: undecidedhigh
status: reopenedopen

Changed November 30, 2010 10:47PM UTC by jitter comment:8

status: openassigned

Changed November 30, 2010 11:44PM UTC by rwaldron comment:9

Nice catch

Changed December 09, 2010 05:48PM UTC by john comment:10

status: assignedpending

The approach taken in #7500 is certainly different but it covers the case handled here (and in a much better way). Can you please re-test now that the code is landed? Thanks!

Changed December 09, 2010 07:10PM UTC by rwaldron comment:11

resolution: → worksforme
status: pendingclosed

I just ran the test against all the supported browsers using jQuery 0 GIT and it no longer throws an exception.

Changed January 31, 2011 05:53PM UTC by john comment:12

version: 1.4.41.5

There wasn't a 1.4.5 release, was actually 1.5.

Changed January 31, 2011 05:55PM UTC by john comment:13

milestone: 1.4.51.5

There was no 1.4.5 release, was actually 1.5.