Bug Tracker

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#14282 closed bug (fixed)

Don't call getPreventDefault() if there is a defaultPrevented property

Reported by: dmethvin Owned by: dmethvin
Priority: high Milestone: 1.11/2.1
Component: event Version: 1.10.2
Keywords: dbr Cc:
Blocked by: Blocking:

Description

See ​https://github.com/jquery/jquery/pull/1294

Change History (20)

comment:1 Changed 10 years ago by m_gol

On 2.x we could probably implement defaultPrevented using an ES5 getter? 1.x requires typeof checks, unfortunately.

comment:2 Changed 10 years ago by m_gol

OTH implementation using a getter would be larger so maybe it's better to use in in 2.x.

comment:3 Changed 10 years ago by dmethvin

ES5 features tend to be slow, so the typeof check may be the best for both branches.

comment:4 Changed 10 years ago by m_gol

typeof on both or typeof in 1.x & in in 2.x? Would be shorter.

comment:5 Changed 10 years ago by m_gol

I agree on the ES5 case, though, especially that Android 2.3 devices aren't demons of speed.

comment:6 Changed 10 years ago by dmethvin

Component: unfiled → event
Milestone: None → 1.11/2.1
Priority: undecided → high
Status: new → open

Note to all who feel compelled to comment here: We are aware of the message, which is just a warning and has no effect on functionality. Do not post "me toos" or "when will this be fixed" here. It's scheduled to be fixed in the next release as shown in the status.

Note that even after the new vesion is released, older jQuery versions will continue to generate this message forever -- or until Chrome decides to remove the message.

comment:7 Changed 10 years ago by dmethvin

#14320 is a duplicate of this ticket.

comment:8 Changed 10 years ago by dmethvin

Owner: set to dmethvin
Status: open → assigned

comment:9 Changed 10 years ago by Dave Methvin

Resolution: → fixed
Status: assigned → closed

Fix #14282. Don't fondle getPreventDefault if preventDefault exists. Close gh-1365.

Changeset: 4671ef15c2d62962048fd4863911146fcc085f26

comment:10 Changed 10 years ago by dexter

I tested it with the 1.10.2 (as scheduled) release and i still get this message.

comment:12 Changed 10 years ago by m_gol

@dexter: please pay more attention next time, the bug was reported to exist exactly in the 1.10.2 you mentioned, it'll be fixed in 1.11. Beta is available.

Last edited 10 years ago by m_gol (previous) (diff)

comment:13 Changed 10 years ago by m_gol

#14546 is a duplicate of this ticket.

comment:16 Changed 10 years ago by anonymous

Problem went away for me using 1.11-beta2 linked above.

comment:19 Changed 10 years ago by scottgonzalez

Keywords: dbr added

comment:21 Changed 9 years ago by Timmy Willison

#14601 is a duplicate of this ticket.

comment:22 Changed 9 years ago by Timmy Willison

#14599 is a duplicate of this ticket.

comment:23 Changed 9 years ago by scottgonzalez

#14679 is a duplicate of this ticket.

comment:24 Changed 9 years ago by Timmy Willison

#14713 is a duplicate of this ticket.

comment:25 Changed 9 years ago by anonymous

#14713 is a duplicate of this ticket. ​hussvamp​Svartmögel​mögel i hus

comment:26 Changed 9 years ago by anonymous

#14600 is a duplicate of this ticket. ​rörinspektion​Fuktutredning​mögel badrum

Note: See TracTickets for help on using tickets.