Opened 12 years ago
Closed 11 years ago
#10416 closed bug (fixed)
defaultDisplay returns block instead of table-row for a tr in FF
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | low | Milestone: | 1.next |
Component: | effects | Version: | 1.6.4 |
Keywords: | FF | Cc: | |
Blocked by: | Blocking: |
Description
.toggle(true/false) on <tr/> may sometimes not behave properly on table with "colspan" See fiddle example, the row on "Bad|Table" get collapsed.
Using .hide()/.show() will also trigger the same problem
Change History (27)
comment:1 Changed 12 years ago by
Component: | unfiled → effects |
---|---|
Priority: | undecided → low |
Resolution: | → invalid |
Status: | new → closed |
comment:2 Changed 12 years ago by
The original post is appended to the table.
The two "tables", one is good (expected result) and one is bad (buggy). The different is due to the usage of toggle() function.
comment:3 Changed 12 years ago by
Resolution: | invalid |
---|---|
Status: | closed → reopened |
Summary: | toggle() may not work on table row <tr/> properly → defaultDisplay returns block instead of table-row for a tr in FF |
Ok, I read that wrong. But it actually worked for me in Chrome and IE6. It seems this is only an issue in Firefox.
comment:4 Changed 12 years ago by
Milestone: | None → 1.next |
---|---|
Status: | reopened → open |
comment:5 Changed 12 years ago by
Owner: | set to Rick Waldron |
---|---|
Status: | open → assigned |
comment:6 Changed 12 years ago by
I've only checked FF 7 so far: http://jsfiddle.net/timmywil/mh8mF/9/
comment:7 Changed 12 years ago by
Milestone: | 1.next → 1.7 |
---|
comment:8 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Landing pull request 530. Fixes coniditional path for tr, td defaultDisplay() calls. Fixes #10416.
More Details:
comment:9 Changed 12 years ago by
Revert "Landing pull request 530. Fixes coniditional path for tr, td defaultDisplay() calls. Fixes #10416." Fixes #10622.
This reverts commit 22f2e8b3dc18dede5f1ccb28cbdf8cb5bcde115f.
Changeset: 0752687612d190f608e64181148ced1a4adfa5d6
comment:10 Changed 12 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:11 Changed 12 years ago by
Milestone: | 1.7 → 1.7.1 |
---|---|
Owner: | changed from Rick Waldron to Timmy Willison |
Status: | reopened → assigned |
comment:13 Changed 12 years ago by
http://jsfiddle.net/davidtong/gxNeD/
Try it in Chrome/IE and then in FF. The red console div should be empty in Chrome/IE, but in FF it says 'block'
My workaround:
var old_display = j_div.css('display'); cache custom display value (e.g. display:table-cell)
j_div.detach().hide(); upon detach, j_div.css('display') returns 'block' even if we set display:table-cell in the CSS
$j._data(j_div[0], "olddisplay", old_display);
comment:15 Changed 12 years ago by
To note, the original fix for this bug caused a regression and we plan on revisiting the issue during the 1.7 lifecycle.
comment:16 Changed 12 years ago by
Milestone: | 1.7.1 → 1.next |
---|
comment:17 Changed 12 years ago by
re: rwaldron
Tested on FF 3.6 and FF 7. They both report "block". Chrome and IE return "" (empty string).
comment:19 Changed 11 years ago by
fully reduced test case: http://jsfiddle.net/73EZY/ confirmed still present in FF12
comment:20 Changed 11 years ago by
Keywords: | FF added |
---|
comment:23 follow-up: 24 Changed 11 years ago by
If this is a bug, it's easy to work around. Check out what happens when you detach
the entire table: http://jsfiddle.net/73EZY/1/
comment:24 Changed 11 years ago by
Replying to gibson042:
If this is a bug, it's easy to work around. Check out what happens when you
detach
the entire table: http://jsfiddle.net/73EZY/1/
This example doesn't seems related to the original bug. This is just an example of usage, which doesn't even hit the bug situation.
comment:26 Changed 11 years ago by
Owner: | Timmy Willison deleted |
---|---|
Status: | assigned → open |
comment:27 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | open → closed |
Fix #10416. Don't trust computed styles on detached elements. Close gh-941.
Changeset: bea5ecbba72f22e8924186d9b81839122ec86aef
Valid html needs to be appended to the table. See http://jsfiddle.net/timmywil/mh8mF/4/