#10416 closed bug (fixed)

Opened October 04, 2011 11:38AM UTC

Closed October 29, 2012 03:40AM UTC

defaultDisplay returns block instead of table-row for a tr in FF

Reported by:	kennyk@peplink.com	Owned by:
Priority:	low	Milestone:	1.next
Component:	effects	Version:	1.6.4
Keywords:	FF	Cc:
Blocked by:		Blocking:

Description

http://jsfiddle.net/mh8mF/

.toggle(true/false) on <tr/> may sometimes not behave properly on table with "colspan"

See fiddle example, the row on "Bad|Table" get collapsed.

Using .hide()/.show() will also trigger the same problem

Attachments (0)

Change History (27)

Changed October 04, 2011 01:43PM UTC by timmywil comment:1

component:	unfiled → effects
priority:	undecided → low
resolution:	→ invalid
status:	new → closed

Valid html needs to be appended to the table. See http://jsfiddle.net/timmywil/mh8mF/4/

Changed October 04, 2011 04:07PM UTC by kennyk@peplink.com comment:2

The original post is appended to the table.

The two "tables", one is good (expected result) and one is bad (buggy).

The different is due to the usage of toggle() function.

Changed October 04, 2011 05:07PM UTC by timmywil comment:3

resolution:	invalid
status:	closed → reopened
summary:	toggle() may not work on table row <tr/> properly → defaultDisplay returns block instead of table-row for a tr in FF

Ok, I read that wrong. But it actually worked for me in Chrome and IE6. It seems this is only an issue in Firefox.

Changed October 04, 2011 05:08PM UTC by timmywil comment:4

milestone:	None → 1.next
status:	reopened → open

Changed October 04, 2011 05:11PM UTC by rwaldron comment:5

owner:	→ rwaldron
status:	open → assigned

Changed October 04, 2011 05:27PM UTC by timmywil comment:6

I've only checked FF 7 so far: http://jsfiddle.net/timmywil/mh8mF/9/

Changed October 04, 2011 08:02PM UTC by timmywil comment:7

milestone:	1.next → 1.7

Changed October 04, 2011 09:50PM UTC by Rick Waldron comment:8

resolution:	→ fixed
status:	assigned → closed

Landing pull request 530. Fixes coniditional path for tr, td defaultDisplay() calls. Fixes #10416.

More Details:

Changeset: 22f2e8b3dc18dede5f1ccb28cbdf8cb5bcde115f

Changed October 31, 2011 09:32PM UTC by timmywil comment:9

Revert "Landing pull request 530. Fixes coniditional path for tr, td defaultDisplay() calls. Fixes #10416." Fixes #10622.

This reverts commit 22f2e8b3dc18dede5f1ccb28cbdf8cb5bcde115f.

Changeset: 0752687612d190f608e64181148ced1a4adfa5d6

Changed October 31, 2011 09:33PM UTC by timmywil comment:10

resolution:	fixed
status:	closed → reopened

Changed October 31, 2011 09:34PM UTC by timmywil comment:11

milestone:	1.7 → 1.7.1
owner:	rwaldron → timmywil
status:	reopened → assigned

Changed November 09, 2011 08:54PM UTC by rwaldron comment:12

#10741 is a duplicate of this ticket.

Changed November 09, 2011 08:59PM UTC by davidtwtong@gmail.com comment:13

http://jsfiddle.net/davidtong/gxNeD/

Try it in Chrome/IE and then in FF. The red console div should be empty in Chrome/IE, but in FF it says 'block'

My workaround:

var old_display = j_div.css('display'); cache custom display value (e.g. display:table-cell)

j_div.detach().hide(); upon detach, j_div.css('display') returns 'block' even if we set display:table-cell in the CSS

$j._data(j_div[0], "olddisplay", old_display);

Changed November 09, 2011 09:02PM UTC by rwaldron comment:14

Which version of FF are you testing in?

Changed November 09, 2011 09:04PM UTC by rwaldron comment:15

To note, the original fix for this bug caused a regression and we plan on revisiting the issue during the 1.7 lifecycle.

Changed November 14, 2011 05:13PM UTC by rwaldron comment:16

milestone:	1.7.1 → 1.next

Changed November 15, 2011 08:55PM UTC by davidalism comment:17

re: rwaldron

Tested on FF 3.6 and FF 7. They both report "block". Chrome and IE return "" (empty string).

Changed March 17, 2012 03:52AM UTC by mikesherov comment:18

#10918 is a duplicate of this ticket.

Changed June 02, 2012 08:28PM UTC by mikesherov comment:19

_comment0:	fully reduced test case: http://jsfiddle.net/73EZY/ → 1338668949410292

fully reduced test case: http://jsfiddle.net/73EZY/ confirmed still present in FF12

Changed June 02, 2012 08:30PM UTC by mikesherov comment:20

keywords:	→ FF

Changed June 03, 2012 01:07AM UTC by gibson042 comment:21

Is this a job for wrapMap?

Changed June 03, 2012 02:59AM UTC by mikesherov comment:22

This looks like a bug in FF itself. Gibson042, can you confirm?

Changed June 03, 2012 04:18AM UTC by gibson042 comment:23

If this is a bug, it's easy to work around. Check out what happens when you detach the entire table: http://jsfiddle.net/73EZY/1/

Changed July 25, 2012 05:48AM UTC by anonymous comment:24

Replying to [comment:23 gibson042]: