Remove Firefox deprecated nodeValue, getAttributeNode, specified
|Reported by:||dmethvin||Owned by:||timmywil|
Firefox 13 generates a pretty large set of warnings in our attribute unit tests:
Use of getAttributeNode() is deprecated. Use getAttribute() instead. Use of attributes' nodeValue attribute is deprecated. Use value instead. Use of document.createAttribute() is deprecated. Use element.setAttribute() instead. Use of attributes' specified attribute is deprecated. It always returns true.
The fact that .specified is already broken may already be causing some bugs. We should either 1) remove these uses entirely or 2) feature test them so we don't use them in browsers where they're unsupported.
Ideally we'd have a way to do that feature testing without making Firefox blurt something out on the console. People are really sensitive about that, and no amount of reasoning will make them understand that a warning does not equate to an error. See #4774, #7291, #7535, and #10531 for example.
Change History (36)
comment:1 Changed 3 years ago by dmethvin
- Component changed from unfiled to attributes
- Milestone changed from None to 1.9
- Priority changed from undecided to high
- Status changed from new to open
comment:4 Changed 3 years ago by dmethvin
- Summary changed from Remove/avoid deprecated attribute features to Remove Firefox deprecated nodeValue, getAttributeNode, specified
comment:12 Changed 3 years ago by timmywil
- Owner set to timmywil
- Status changed from open to assigned
comment:27 Changed 3 years ago by Timmy Willison
- Resolution set to fixed
- Status changed from assigned to closed