Bug Tracker

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11969 closed bug (fixed)

Missing null check when gathering siblings

Reported by: dmethvin Owned by: dmethvin
Priority: blocker Milestone: 1.8
Component: selector Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

Description

Ref ​http://bugs.jqueryui.com/ticket/8409

Not sure why the null check for cur was removed.

Change History (8)

comment:1 Changed 11 years ago by dmethvin

Component: unfiled → selector
Milestone: None → 1.8
Priority: undecided → blocker
Status: new → open

Reported by FJ1 in IRC.

comment:2 Changed 11 years ago by Timmy Willison

Looks like this reduction commit removed the null check by accident: ​https://github.com/jquery/jquery/commit/df254d47e43e6e1652b20a3b338b26f634cd2b2a#src/traversing.js

comment:3 Changed 11 years ago by dmethvin

Owner: set to dmethvin
Status: open → assigned

comment:4 Changed 11 years ago by dmethvin

#11968 is a duplicate of this ticket.

comment:5 Changed 11 years ago by Dave Methvin

Resolution: → fixed
Status: assigned → closed

Fix #11969. Never a null moment when checking siblings.

Changeset: cde4c326b82af4679026a202f02799e9fbd18cb4

comment:6 Changed 11 years ago by FlashJunior

thank you so much! all my tests are working now!

comment:7 Changed 11 years ago by dmethvin

#12019 is a duplicate of this ticket.

comment:8 Changed 11 years ago by dmethvin

#12053 is a duplicate of this ticket.

Note: See TracTickets for help on using tickets.