Opened 11 years ago
Closed 11 years ago
#9233 closed bug (fixed)
getPixelVaue method in jquery
| Reported by: | Owned by: | timmywil | |
|---|---|---|---|
| Priority: | low | Milestone: | 1.next |
| Component: | css | Version: | 1.6 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Change History (7)
comment:1 follow-up: 2 Changed 11 years ago by
| Component: | unfiled → misc |
|---|---|
| Owner: | set to [email protected]… |
| Status: | new → pending |
comment:2 Changed 11 years ago by
| Status: | pending → new |
|---|
please run it in IE(my browser is version 8).
comment:3 Changed 11 years ago by
| Component: | misc → css |
|---|---|
| Owner: | changed from [email protected]… to timmywil |
| Priority: | undecided → low |
| Status: | new → assigned |
I can't think of a use case where that would cause something to break, but I'll take a look as to why it's changing the runtime value.
comment:4 Changed 11 years ago by
Looks like the change here had some copypasta: https://github.com/jquery/jquery/commit/8099cdce800d45109b961e3521fc0080e9a876c6
I'll open a PR just in case we care to fix this.
comment:6 Changed 11 years ago by
Nope, no copypasta there, everything I did was intentional. If you'd like to discuss my changes line-by-line, I'd be glad to. The problem was runtimeStyle throwing exceptions in Opera, but clearly we had no tests for cases like this. (see: #7608 )
TBH, that fiddle feels contrived...
comment:7 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Landing pull request 562. Make sure runtimeStyle isn't affected by dimensions. Fixes #9233.
More Details:
Thanks for taking the time to contribute to the jQuery project! Please provide a reduced test case on http://jsFiddle.net that reproduces the issue experienced to help us assess your ticket!
Additionally, test against the
jQuery (edge)version to ensure the issue still exists.