Skip to main content

Bug Tracker

Side navigation

#9233 closed bug (fixed)

Opened May 11, 2011 10:27AM UTC

Closed October 28, 2011 02:55PM UTC

getPixelVaue method in jquery

Reported by: zhengzongyi@gmail.com Owned by: timmywil
Priority: low Milestone: 1.next
Component: css Version: 1.6
Keywords: Cc:
Blocked by: Blocking:
Description

hi:

in jquery 1.6, I think this has a bug

rsLeft = elem.runtimeStyle && elem.runtimeStyle[ name ]

in jquery 1.4, this is

rsLeft = elem.runtimeStyle.left;

jquery 1.6 line #6422

jquery 1.4.3 line #5244

Attachments (0)
Change History (7)

Changed May 11, 2011 12:10PM UTC by addyosmani comment:1

component: unfiledmisc
owner: → zhengzongyi@gmail.com
status: newpending

Thanks for taking the time to contribute to the jQuery project! Please provide a reduced test case on http://jsFiddle.net that reproduces the issue experienced to help us assess your ticket!

Additionally, test against the jQuery (edge) version to ensure the issue still exists.

Changed May 12, 2011 02:05AM UTC by zhengzongyi@gmail.com comment:2

status: pendingnew

please run it in IE(my browser is version 8).

http://jsfiddle.net/eF4YQ/

Changed May 12, 2011 02:54PM UTC by timmywil comment:3

component: misccss
owner: zhengzongyi@gmail.comtimmywil
priority: undecidedlow
status: newassigned

I can't think of a use case where that would cause something to break, but I'll take a look as to why it's changing the runtime value.

Changed October 23, 2011 02:50PM UTC by mikesherov comment:4

Looks like the change here had some copypasta: https://github.com/jquery/jquery/commit/8099cdce800d45109b961e3521fc0080e9a876c6

I'll open a PR just in case we care to fix this.

Changed October 23, 2011 03:56PM UTC by mikesherov comment:5

Changed October 23, 2011 05:12PM UTC by rwaldron comment:6

Nope, no copypasta there, everything I did was intentional. If you'd like to discuss my changes line-by-line, I'd be glad to. The problem was runtimeStyle throwing exceptions in Opera, but clearly we had no tests for cases like this. (see: #7608 )

TBH, that fiddle feels contrived...

Changed October 28, 2011 02:55PM UTC by Mike Sherov comment:7

resolution: → fixed
status: assignedclosed

Landing pull request 562. Make sure runtimeStyle isn't affected by dimensions. Fixes #9233.

More Details:

Changeset: fa0e801f52cdc97832ef0b696caa1eda33fc6b36