val() returns innerHTML for button elements in IE

[dmuir]

val() returns the value of the value property in FF, but returns the value of innerHTML in IE.

jQuery 1.1.4 did not have this bug.

html: <button value="myValue">Click Me</button>

js: alert($('button').val());

IE: alerts "Click Me"

FF: alerts "myValue"

[dmuir]

using .attr('value') does not work around this issue either

[dmuir]

must have been seeing things... tested again with 1.1.4 and it doesn't work there either. The only solution I have is to retrieve the html for the button element and do a regex to extract the value attribute. IE's button dom element does not have a property storing the value (it is overwritten by the button's innerHTML).

[davidserduke]

Weird. I see the same thing you do. Using the debugger the "value" as assigned by the attribute just isn't stored anywhere and appears to be overwritten by the innerHTML. It's interesting if you overwrite the value it will then be correct like:

$("button").val("newValue");
alert($("button").val());

alerts "newValue" in both IE and FF. I hate to say it but there does not appear to be an easy cross-browser fix. :(

[john]

Doesn't look like this can be resolved, unfortunately.

[luka.kladari]

i've dug up a fairly dirty/ugly workaround (credit: ​http://odyniec.net/projects/iefixbuttons/):

var rawval = $("button").get(0).outerHTML.match(/value\s*=\s*['"](['"]*)['"]/);

var val = (rawval ? rawval[1] : );

to be combined with if($.browser.msie)

this will fail in cases like value="bla'bla'bla", which are perfectly valid in HTML

can someone with better JS regex skills than me figure out how to catch the opening character and match everything until it shows up again? I believe that would be a fairly robust (albeit ugly) fix, which could be implemented in jquery core?

[flesler]

aButton.attributes.value.nodeValue returns the value on IE.

I think this can be indeed worked around.

[jollytoad]

Can also use:

buttonElement.getAttributeNode('value').value

[dmethvin]

Bug #3259 has a test case and link to further discussion.

[dmethvin]

This seems to be working now, tested in 1.4.2 and IE8.

[Anthony Johnston]

Replying to dmethvin:

This seems to be working now, tested in 1.4.2 and IE8.

doesn't work in ie7 or wp7 (which is also ie7) comment 6 has the answer

[anonymous]

As stated above this issue is not fixed yet for IE7 in jQuery 1.4.4. The workaround mentioned in comment:6 works for IE7 on WinXP and should be implemented for the val and attr functions.

Unfortunately, this issue tracker in use here doesn't permit to reopen the bug for whatever reason.

[jitter]

​test case

[jitter]

#7938 is a duplicate of this ticket.

[robert.clark]

I have an updated patch against git that handles reading & setting button values via .val() & .attr('value') as well as .removeAttr('value'). I don't seem to be able to attach it to this ticket, though. Shouldn't there be an "Attach file" button somewhere?

[dmuir]

can't see where to add an attachment either... but I'm curious to see what your solution is.

[robert.clark]

It's nothing especially clever, just some special-cases that use getAttributeNode, setAttributeNode & removeAttributeNode. The special-cases target only the value attribute on buttons in IE7 (and lower) to minimise the impact.

I've stuck it up here: ​https://gist.github.com/776092

[julien.garand+jquery@…]

Hi,

Please consider the following test case with IE7 : ​http://jsbin.com/ipitu4 Each button is written as

<button value="some value">some code</button>

.

We would expect IE7 to return the correct "value" attribute value when calling

$('button').attr('value');  // BUG

... It doesn't !

The solution is given by the third button

$('button').get(0).getAttributeNode('value').value;   //CORRECT

Regards, Julien

[anonymous]

Replying to julien.garand+jquery@…:

Same test case with jsFiddle : ​http://jsfiddle.net/sKuHr/1/

[robert.clark]

Here's a new patch which tests for the bug instead of using browser detection:

​https://gist.github.com/845759

[robert.clark]

And another, stripped-down, patch which only fixes the most common usage case (reading the value attribute):

​https://gist.github.com/845799

[timmywil]

Fix value attribute and val for value on button elements. Fixes #1954

Changeset: 34d80709ce9bd583f6f5dd17e9bffa2fb7cff3c5