Sizzle's element-rooted QSA strategy (i.e. attaching a temporary id) does not account for comma and other other selector divisions

[Timmy Willison]

This has been a known issue for a while, but I don't see a ticket specifically for this. We recently received this pull: ​https://github.com/jquery/sizzle/pull/104. Unfortunately, the issue is more complicated than just accounting for commas for a couple reasons.

• There are several other ways a selector can have multiple divisions. Comma is the most common, but several pseudo selectors and perhaps others can also have this effect.
• escaped commas are valid in selectors.

I'm going to take a crack at this as well for 1.8.

[Igin]

This issue exists from 1.4.3 to 1.7.2

[Timmy Willison]

Woops, looks like I was the one who created a ticket on this matter and didn't see it. This ticket has a better description, but here is the test case from that ticket. ​http://jsfiddle.net/timmywil/tDgXy/

[Timmy Willison]

#10525 is a duplicate of this ticket.

[Timmy Willison]

#11842 is a duplicate of this ticket.

[Timmy Willison]

I had the :not selector in mind when I was thinking of pseudos that create selector divisions, but it turns out :not only accepts simple selectors by spec (meaning no other divisions allowed). Having gone through this list(​http://www.w3.org/TR/selectors/#selectors), comma seems to be the only acceptable division. Landing a fix now.

[Timmy Willison]

Update Sizzle: adds selector divisions for element-rooted QSA in the Dupont strategy. Fixes #11814.

Changeset: ccffddd89b5fd6ce9388d1db52361c59649b132a