#10692 closed enhancement (fixed)
Configure the jshint options to more accurately match the style guide
| Reported by: | mikesherov | Owned by: | mikesherov |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7.2 |
| Component: | build | Version: | 1.7 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description (last modified by )
JSHint's configuration options are way better than JSLint's.
In particular, the "undef" option is useful, and would only require minor changes to core code.
1.8?
Change History (18)
comment:1 Changed 12 years ago by
| Component: | unfiled → misc |
|---|---|
| Keywords: | 1.8-discuss added |
| Priority: | undecided → low |
| Status: | new → open |
comment:2 follow-up: 4 Changed 12 years ago by
| Component: | misc → build |
|---|---|
| Milestone: | None → 1.7.1 |
Yeah I would love to have a way to catch undeclared variables. Scary.
comment:4 Changed 12 years ago by
Replying to dmethvin:
Yeah I would love to have a way to catch undeclared variables. Scary.
That's another option we can switch on: "undef"
comment:5 Changed 12 years ago by
@mikesherov - before any code gets written for this... I want to show you a "build tool" system that @cowboy has been developing, it might make easy work of this.
comment:6 Changed 12 years ago by
| Milestone: | 1.7.1 → 1.8 |
|---|
comment:7 Changed 12 years ago by
| Summary: | use JSHint for the build instead of JSLint → Configure the jshint options to more accurately match the style guide |
|---|
comment:8 Changed 12 years ago by
+1, We already use JSHint, but the options need to be configured to match the styleguide. Code should be reorganized so onevar and other available options will pass.
comment:9 Changed 12 years ago by
Are you sure? Git version seems to indicate that we're using JSLint instead of JSHint:
https://github.com/jquery/jquery/blob/master/build/lib/jslint.js https://github.com/jquery/jquery/blob/master/build/jslint-check.js
comment:10 Changed 12 years ago by
You know what, I use jshint locally so often, I couldn't believe we didn't use it. woooops.
comment:12 Changed 12 years ago by
I'll have a PR with just an in place change shortly. After the change is in place, I'll go immediately to work on onevar and undef.
comment:15 Changed 12 years ago by
| Owner: | set to mikesherov |
|---|---|
| Status: | open → assigned |
comment:16 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:17 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fix #10692. JSLint is dead! Long live JSHint!
Still needs this sizzle PR: https://github.com/jquery/sizzle/pull/82
Changeset: 98386cfd775fdfa7837ccbec173b04f1e6d57896
comment:18 Changed 11 years ago by
| Keywords: | 1.8-discuss removed |
|---|---|
| Milestone: | 1.8 → 1.7.2 |
There was no reason to wait until 1.8 for this, probably true for any of the build or behind-the-scenes changes if they're easy to do.
+1 "onevar" changes are DEFINITELY welcome.