Skip to main content

Bug Tracker

Side navigation

#10691 closed enhancement (fixed)

Opened November 06, 2011 03:32AM UTC

Closed November 06, 2011 08:30PM UTC

Last modified March 08, 2012 09:23PM UTC

remove all occurrences of the "equals" and "same" function in the unit tests`

Reported by: mikesherov Owned by:
Priority: low Milestone: 1.7.1
Component: misc Version: 1.7
Keywords: Cc:
Blocked by: Blocking:

in testrunner.js:

	window.equals = window.equal;
	window.same = window.deepEqual;	

it's time this aliases went bye bye. 1.8?

Attachments (0)
Change History (11)

Changed November 06, 2011 03:33AM UTC by rwaldron comment:1

component: unfiledmisc
keywords: → 1.8-discuss
milestone: None1.8
priority: undecidedlow
status: newopen
type: bugenhancement

+1 and Yay!

Changed November 06, 2011 04:03AM UTC by mikesherov comment:2

Changed November 06, 2011 01:56PM UTC by dmethvin comment:3

Since there's a PR we should either land this ASAP or close the PR since it's going to get awfully stale.

Changed November 06, 2011 02:21PM UTC by mikesherov comment:4

Yeah. I guess 1.7.1 then? I tested in FF and Chrome from a hosted copy (so isLocal was false and all tests ran). No reason this shouldnt work in other browsers.

Changed November 06, 2011 08:30PM UTC by Mike Sherov comment:5

resolution: → fixed
status: openclosed

Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit.

Changeset: f35ba5e699c15a1987baa389dbd4fc99f7a7eb03

Changed November 06, 2011 10:05PM UTC by dmethvin comment:6


Changed November 09, 2011 09:39AM UTC by gnarf comment:7

Thanks Mike - someone has needed to do this for quite a while now... Glad you took the initiative!

Changed November 09, 2011 01:14PM UTC by rwaldron comment:8


Changed November 09, 2011 02:05PM UTC by mikesherov comment:9

Rick deserves the credit here. A midnight IRC convo with him caused the change. All I did was find and replace.

Changed November 09, 2011 03:42PM UTC by rwaldron comment:10

Mike deserves the credit for actually doing the dirty work that no one else wanted to do ahaha

Changed December 10, 2011 07:17PM UTC by dmethvin comment:11

keywords: 1.8-discuss