#10691 closed enhancement (fixed)
remove all occurrences of the "equals" and "same" function in the unit tests`
| Reported by: | mikesherov | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7.1 |
| Component: | misc | Version: | 1.7 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
in testrunner.js:
window.equals = window.equal; window.same = window.deepEqual;
it's time this aliases went bye bye. 1.8?
Change History (11)
comment:1 Changed 11 years ago by
| Component: | unfiled → misc |
|---|---|
| Keywords: | 1.8-discuss added |
| Milestone: | None → 1.8 |
| Priority: | undecided → low |
| Status: | new → open |
| Type: | bug → enhancement |
comment:2 Changed 11 years ago by
Here's the pull request: https://github.com/jquery/jquery/pull/580
comment:3 Changed 11 years ago by
Since there's a PR we should either land this ASAP or close the PR since it's going to get awfully stale.
comment:4 Changed 11 years ago by
Yeah. I guess 1.7.1 then? I tested in FF and Chrome from a hosted copy (so isLocal was false and all tests ran). No reason this shouldnt work in other browsers.
comment:5 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit.
Changeset: f35ba5e699c15a1987baa389dbd4fc99f7a7eb03
comment:6 Changed 11 years ago by
| Milestone: | 1.8 → 1.7.1 |
|---|
comment:7 Changed 11 years ago by
Thanks Mike - someone has needed to do this for quite a while now... Glad you took the initiative!
comment:9 Changed 11 years ago by
Rick deserves the credit here. A midnight IRC convo with him caused the change. All I did was find and replace.
comment:10 Changed 11 years ago by
Mike deserves the credit for actually doing the dirty work that no one else wanted to do ahaha
comment:11 Changed 11 years ago by
| Keywords: | 1.8-discuss removed |
|---|
+1 and Yay!