Bug Tracker

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#10691 closed enhancement (fixed)

remove all occurrences of the "equals" and "same" function in the unit tests`

Reported by: mikesherov Owned by:
Priority: low Milestone: 1.7.1
Component: misc Version: 1.7
Keywords: Cc:
Blocked by: Blocking:


in testrunner.js:

	window.equals = window.equal;
	window.same = window.deepEqual;	

it's time this aliases went bye bye. 1.8?

Change History (11)

comment:1 Changed 5 years ago by rwaldron

  • Component changed from unfiled to misc
  • Keywords 1.8-discuss added
  • Milestone changed from None to 1.8
  • Priority changed from undecided to low
  • Status changed from new to open
  • Type changed from bug to enhancement

+1 and Yay!

comment:2 Changed 5 years ago by mikesherov

comment:3 Changed 5 years ago by dmethvin

Since there's a PR we should either land this ASAP or close the PR since it's going to get awfully stale.

comment:4 Changed 5 years ago by mikesherov

Yeah. I guess 1.7.1 then? I tested in FF and Chrome from a hosted copy (so isLocal was false and all tests ran). No reason this shouldnt work in other browsers.

comment:5 Changed 5 years ago by Mike Sherov

  • Resolution set to fixed
  • Status changed from open to closed

Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit.

Changeset: f35ba5e699c15a1987baa389dbd4fc99f7a7eb03

comment:6 Changed 5 years ago by dmethvin

  • Milestone changed from 1.8 to 1.7.1

comment:7 Changed 5 years ago by gnarf

Thanks Mike - someone has needed to do this for quite a while now... Glad you took the initiative!

comment:8 Changed 5 years ago by rwaldron


comment:9 Changed 5 years ago by mikesherov

Rick deserves the credit here. A midnight IRC convo with him caused the change. All I did was find and replace.

comment:10 Changed 5 years ago by rwaldron

Mike deserves the credit for actually doing the dirty work that no one else wanted to do ahaha

comment:11 Changed 4 years ago by dmethvin

  • Keywords 1.8-discuss removed
Note: See TracTickets for help on using tickets.