Skip to main content

Bug Tracker

Side navigation

#10693 closed enhancement (fixed)

Opened November 06, 2011 05:04AM UTC

Closed February 25, 2012 03:54PM UTC

Last modified March 14, 2012 07:51AM UTC

generalize the "test something in an iframe" code in unit tests

Reported by: mikesherov Owned by: mikesherov
Priority: low Milestone: 1.7.2
Component: build Version: 1.7
Keywords: Cc:
Blocked by: Blocking:

there are 3 different pieces of code in 3 different unit test modules:

support.js: supportIFrameTest
selector.js: testIframe
offset.js: testoffset

testIframe and testOffset are almost exact duplicates. supportIFrameTest is close enough. I was about to start writing another one for a ticket I'm trying to fix in event.js, but perhaps it's time to DRY this code and move it into test/data/testinit.js ?

I'd be glad to take a stab at it. 1.8?

Attachments (0)
Change History (4)

Changed November 06, 2011 01:52PM UTC by dmethvin comment:1

component: unfiledbuild
milestone: None1.8
priority: undecidedlow
status: newopen

Sounds like a good idea!

Changed November 28, 2011 02:44AM UTC by mikesherov comment:2

owner: → mikesherov
status: openassigned

Changed February 23, 2012 08:55PM UTC by mikesherov comment:3


Changed February 25, 2012 03:54PM UTC by mikesherov comment:4

resolution: → fixed
status: assignedclosed