Skip to main content

Bug Tracker

Side navigation

#10622 closed bug (fixed)

Opened October 31, 2011 12:58PM UTC

Closed October 31, 2011 09:32PM UTC

Last modified November 01, 2011 04:36PM UTC

.show() does not properly restore CSS-set "display" value

Reported by: warrenparsons Owned by: rwaldron
Priority: blocker Milestone: 1.7
Component: effects Version: 1.7rc1
Keywords: Cc:
Blocked by: Blocking:

I've run into an issue in RC1 (and seemingly B2 as well) where using .show() does not restore an element's original, CSS-specified "display" value. Instead, it sets the element's "display" type to that element's browser-default value.

B1 does not have this issue for me.

I've set up a test case on jsfiddle at:

Attachments (0)
Change History (5)

Changed October 31, 2011 02:27PM UTC by rwaldron comment:1

_comment0: Confirmed, regression.1320071256450402
component: unfiledeffects
milestone: None1.7
owner: → rwaldron
priority: undecidedblocker
status: newassigned

Confirmed: Regression.

Patch to follow.

Changed October 31, 2011 02:29PM UTC by rwaldron comment:2

I believe this was caused by the patch that timmywil and I wrote here:

Changed October 31, 2011 02:34PM UTC by rwaldron comment:3

Further reduced, easier to understand:

Changed October 31, 2011 09:32PM UTC by timmywil comment:4

resolution: → fixed
status: assignedclosed

Revert "Landing pull request 530. Fixes coniditional path for tr, td defaultDisplay() calls. Fixes #10416." Fixes #10622.

This reverts commit 22f2e8b3dc18dede5f1ccb28cbdf8cb5bcde115f.

Changeset: 0752687612d190f608e64181148ced1a4adfa5d6

Changed November 01, 2011 04:36PM UTC by rwaldron comment:5

#10628 is a duplicate of this ticket.