Skip to main content

Bug Tracker

Side navigation

#10679 closed feature (fixed)

Opened November 05, 2011 04:51AM UTC

Closed May 13, 2012 04:52PM UTC

Last modified May 16, 2012 06:04PM UTC

CSS3 vendor prefix support

Reported by: mikesherov Owned by: mikesherov
Priority: low Milestone: 1.8
Component: css Version: 1.7
Keywords: 1.8-discuss Cc:
Blocked by: Blocking:
Description

There are a few bugs, although admittedly edge cases, that effect the css and effects modules due to jQuery not taking into account CSS3: http://bugs.jquery.com/ticket/10413

I'd like to bring CSS3 vendor prefix detection to jQuery as both an exposed and documented feature, but also to address the bugs.

I've already submitted a pull request containing the code: https://github.com/jquery/jquery/pull/528

Please consider this for 1.8

Attachments (0)
Change History (19)

Changed November 05, 2011 04:54AM UTC by mikesherov comment:1

Changed November 05, 2011 06:10PM UTC by timmywil comment:2

component: unfiledcore
keywords: → 1.8-discuss
priority: undecidedlow
status: newopen
version: git1.7

Changed November 05, 2011 08:47PM UTC by rwaldron comment:3

I have a pretty solid prefix detector in Abacus... I'll ping you later with code

Changed November 05, 2011 08:55PM UTC by mikesherov comment:4

Yeah, please do. Also, check out the prefix code from what I wrote in the pull request I listed. Hopefully, they're similar.

Changed November 13, 2011 02:43AM UTC by rwaldron comment:5

This is the prefix detector I wrote for Abacus:

https://github.com/Abacus/Abacus/blob/master/src/abacus.js#L109-115

Changed November 28, 2011 03:05AM UTC by mikesherov comment:6

owner: → mikesherov
status: openassigned

Changed November 28, 2011 03:06AM UTC by mikesherov comment:7

component: corecss

Changed December 13, 2011 01:20PM UTC by mikesherov comment:8

description: There are a few bugs, although admittedly edge cases, that effect the css and effects modules due to jQuery not taking into account CSS3: http://bugs.jquery.com/ticket/10413 \ \ I'd like to bring CSS3 vendor prefix detection to jQuery as both an exposed and documented feature, but also to address the bugs. \ \ I've already submitted a pull request containing the code: https://github.com/jquery/jquery/pull/528 \ \ Please consider this for 1.8There are a few bugs, although admittedly edge cases, that effect the css and effects modules due to jQuery not taking into account CSS3: http://bugs.jquery.com/ticket/10413\ \ I'd like to bring CSS3 vendor prefix detection to jQuery as both an exposed and documented feature, but also to address the bugs. \ \ I've already submitted a pull request containing the code: https://github.com/jquery/jquery/pull/528\ \ Please consider this for 1.8

+1, I'd argue that this is the type of thing people'd want in core jQuery. The homepage of jquery.com touts CSS1-3 support in jQuery (although the "and more" is ambiguous). Vendor prefixed attributes are a part of that, unfortunately, and this can help users of jQuery write a lot less code.

Changed December 13, 2011 04:21PM UTC by jaubourg comment:9

+1, Vendor prefixes are hell but the kind of hell jQuery needs to tackle.

Changed December 13, 2011 06:06PM UTC by dmethvin comment:10

description: There are a few bugs, although admittedly edge cases, that effect the css and effects modules due to jQuery not taking into account CSS3: http://bugs.jquery.com/ticket/10413\ \ I'd like to bring CSS3 vendor prefix detection to jQuery as both an exposed and documented feature, but also to address the bugs. \ \ I've already submitted a pull request containing the code: https://github.com/jquery/jquery/pull/528\ \ Please consider this for 1.8There are a few bugs, although admittedly edge cases, that effect the css and effects modules due to jQuery not taking into account CSS3: http://bugs.jquery.com/ticket/10413 \ \ I'd like to bring CSS3 vendor prefix detection to jQuery as both an exposed and documented feature, but also to address the bugs. \ \ I've already submitted a pull request containing the code: https://github.com/jquery/jquery/pull/528 \ \ Please consider this for 1.8

+1, Since it's pretty common, this does seem like a place where adding bytes is worth it.

Changed December 14, 2011 04:10PM UTC by timmywil comment:11

description: There are a few bugs, although admittedly edge cases, that effect the css and effects modules due to jQuery not taking into account CSS3: http://bugs.jquery.com/ticket/10413 \ \ I'd like to bring CSS3 vendor prefix detection to jQuery as both an exposed and documented feature, but also to address the bugs. \ \ I've already submitted a pull request containing the code: https://github.com/jquery/jquery/pull/528 \ \ Please consider this for 1.8There are a few bugs, although admittedly edge cases, that effect the css and effects modules due to jQuery not taking into account CSS3: http://bugs.jquery.com/ticket/10413\ \ I'd like to bring CSS3 vendor prefix detection to jQuery as both an exposed and documented feature, but also to address the bugs. \ \ I've already submitted a pull request containing the code: https://github.com/jquery/jquery/pull/528\ \ Please consider this for 1.8

+1

Changed December 19, 2011 05:34PM UTC by rwaldron comment:12

description: There are a few bugs, although admittedly edge cases, that effect the css and effects modules due to jQuery not taking into account CSS3: http://bugs.jquery.com/ticket/10413\ \ I'd like to bring CSS3 vendor prefix detection to jQuery as both an exposed and documented feature, but also to address the bugs. \ \ I've already submitted a pull request containing the code: https://github.com/jquery/jquery/pull/528\ \ Please consider this for 1.8There are a few bugs, although admittedly edge cases, that effect the css and effects modules due to jQuery not taking into account CSS3: http://bugs.jquery.com/ticket/10413 \ \ I'd like to bring CSS3 vendor prefix detection to jQuery as both an exposed and documented feature, but also to address the bugs. \ \ I've already submitted a pull request containing the code: https://github.com/jquery/jquery/pull/528 \ \ Please consider this for 1.8

+1

Changed January 18, 2012 12:15AM UTC by mikesherov comment:13

milestone: None1.8

Changed April 06, 2012 11:03PM UTC by mikesherov comment:14

#11565 is a duplicate of this ticket.

Changed April 06, 2012 11:36PM UTC by SineSwiper comment:15

Working code from dupe ticket. This can be plopped into jQuery's root routines easily. Instead of taking a piecemeal approach of adding workarounds manually, this skips all of that BS and just scans through div.style. If it's a vendor-specific property, then the name is normalized, and a cssHook is added. Done. Fin. Put it in!

var div = document.createElement('div');
for (var prop in div.style) {
	// Sanity checks
	if (! /^(Moz|Webkit|O|ms)[A-Z]/.test(prop)) continue;
	if (typeof prop !== 'string')               continue;
	
	var cssProp = prop.replace(/^(Moz|Webkit|O|ms)/, '');
	cssProp = cssProp.charAt(0).toLowerCase() + cssProp.slice(1);
	
	if (!$.cssHooks[cssProp]) $.cssHooks[cssProp] = {
		get: function (elem, computed, extra) { return $.css(elem, prop); },
		set: function (elem, value)           { elem.style[prop] = value; }
	};
}

Changed April 07, 2012 12:40AM UTC by mikesherov comment:16

Thanks for the code snippet! We've already landed a patch in the 1.8pre branch that does almost exactly this. Feel free to comment there too!

Changed April 09, 2012 01:00AM UTC by SineSwiper comment:17

_comment0: Yes, I would, but I can't see the code from that branch. Do you have the code hash or a link?1333933424774634

Thanks.

Changed May 13, 2012 04:52PM UTC by dmethvin comment:18

resolution: → fixed
status: assignedclosed

Changed May 16, 2012 06:04PM UTC by Mike Sherov comment:19

Fix #10413, #10679. Fix box-sizing:border-box and add css vendor prefix support.

Changeset: 5376a809c0d2bee4b7872847c2821e458dfdcc3b