Skip to main content

Bug Tracker

Side navigation

#9385 closed enhancement (fixed)

Opened May 22, 2011 07:02PM UTC

Closed June 18, 2012 04:32PM UTC

Deprecate jQuery.browser

Reported by: Owned by: rwaldron
Priority: blocker Milestone: 1.8
Component: support Version: 1.6.1
Keywords: 1.8-discuss Cc:
Blocked by: Blocking:

Add Google Chrome to jQuery.browser, that is all :)

Attachments (0)
Change History (35)

Changed May 22, 2011 07:27PM UTC by john comment:1

keywords: → 1.7-discuss

Nominating ticket for 1.7 discussion.

Changed May 22, 2011 08:12PM UTC by rwaldron comment:2

-1, Adding new support to jQuery.browser might be perceived as encouragement to use it.

Changed May 23, 2011 12:59AM UTC by jaubourg comment:3


Changed May 23, 2011 05:02AM UTC by timmywil comment:4

-1, I wish jQuery.browser wasn't there.

Changed May 23, 2011 04:32PM UTC by comment:5


(While I'm on the Chrome team, this is my personal opinion)

$.browser.safari was renamed to webkit a few versions ago to preempt this request.

Changed May 24, 2011 12:31AM UTC by timmywil comment:6

component: unfiledsupport
priority: undecidedlow
status: newopen

Changed May 24, 2011 10:16PM UTC by dmethvin comment:7

+1, Gentlemen, what are our intentions with respect to jQuery.browser? If we are going to let it languish then let's just yank it with the reasoning that we aren't maintaining it anyway. The docs say it will be a supported plugin eventually. Will the plugin return Chrome?

Changed June 03, 2011 02:09PM UTC by john comment:8

-1, I'd prefer to stop updating jQuery.browser

Changed June 04, 2011 10:16PM UTC by addyosmani comment:9


Changed June 05, 2011 10:21PM UTC by ajpiano comment:10

+1, Totally agree with Dave here. If it's there, it should at least be sensible. Otherwise, let's actually get rid of the damn thing.

Changed June 06, 2011 03:23PM UTC by scottgonzalez comment:11


Changed June 20, 2011 01:12PM UTC by ThiefMaster comment:12

+1, sometimes there are browser bugs which are not testable through $.support

Changed June 20, 2011 01:59PM UTC by rwaldron comment:13

owner: → rwaldron
status: openassigned

Changed July 12, 2011 03:06PM UTC by dmethvin comment:14

milestone: 1.next1.7
priority: lowblocker

Changed August 04, 2011 09:32PM UTC by Dave Methvin comment:15

resolution: → fixed
status: assignedclosed

Merge pull request #417 from rwldrn/9385

Begrudgingly adds chrome detection to jQuery.browser (1.7). Fixes #9385

Changeset: 5417a2cf6b629b5bf3103454a5a6cab2181924e8

Changed August 26, 2011 01:51PM UTC by Krinkle comment:16

What about Safari ? Now there's Chrome but no Safari, that's odd/annoying. Perhaps add back safari as well ?

Changed August 26, 2011 02:15PM UTC by timmywil comment:17

Revert "Updated version numbers; Fixes #9385"

This reverts commit 09fe3ea265d730cc5e2dd2705d5a60ffd382d166.

Changeset: e2187f49637c62d9b72ec852c9213a20778e63d3

Changed August 26, 2011 02:15PM UTC by timmywil comment:18

Revert "Begrudgingly adds chrome detection to jQuery.browser (1.7). Fixes #9385"

This reverts commit dd93d0eb32dc638ff3319792a885acd6d3c25c30.

Changeset: 2a045f8269de9ef936bfaa2efbf71b9962385cf8

Changed August 26, 2011 02:18PM UTC by timmywil comment:19

resolution: fixed
status: closedreopened

Reopened for 1.7.

Changed August 26, 2011 02:18PM UTC by timmywil comment:20

status: reopenedopen

Changed September 22, 2011 01:16PM UTC by rwaldron comment:21

keywords: 1.7-discuss1.8-discuss
milestone: 1.71.8

Changed December 13, 2011 01:17PM UTC by mikesherov comment:22

+1, If we're going to have a jQuery.browser at all, it should be able to detect Chrome. This vote becomes a -1 if instead we decide to gut jQuery.browser completely.

Changed December 13, 2011 01:41PM UTC by mikesherov comment:23

-1, Changing to -1 because I just saw that moving jQuery.browser to a compatibility plugin was up for a vote. :-)

Changed December 13, 2011 04:00PM UTC by jaubourg comment:24

+0, if we move $.browser to an official plugin, then we can have this kind of change. Else, no.

Changed December 13, 2011 05:19PM UTC by dmethvin comment:25

We voted this down in 1.7 but if we are planning to abandon maintenance of jQuery.browser we should determine a sunset version and get rid of it.

Our current docs say it will be turned into a plugin, I think the community's assumption would be that it is an official and maintained plugin. If we aren't going to maintain this we need to say so ASAP and provide other alternatives to avoid breaking code. (Although if it uses jQuery.browser it's already broken ... ba-dum-pum!)

Changed December 13, 2011 05:24PM UTC by jzaefferer comment:26

-1, deprecated already anyway

Changed December 14, 2011 04:01PM UTC by timmywil comment:27

-1, Never ever

Changed December 19, 2011 05:13PM UTC by rwaldron comment:28

-1, still opposed.

Changed January 17, 2012 03:14PM UTC by rwaldron comment:29

#11181 is a duplicate of this ticket.

Changed January 30, 2012 05:29PM UTC by dmethvin comment:30

OK, we're keeping this in as-is for 1.8 but will trumpet that it is being removed into a plugin as of 1.9. It is already deprecated in the docs.

Changed January 30, 2012 05:32PM UTC by dmethvin comment:31

Changed May 08, 2012 08:27PM UTC by dmethvin comment:32

summary: Add Google Chrome to jQuery.browserDeprecate jQuery.browser

There will be a separate plugin as of 1.8, and jQuery.browser will disappear from core as of 1.9. You can include the plugin as of 1.8 if desired, or substitute your own flaky-and-fragile regex for our flaky-and-fragile regex, or (even better) just **stop using browser sniffing**.

Changed May 08, 2012 08:40PM UTC by rwaldron comment:33

Changed May 18, 2012 01:45AM UTC by dmethvin comment:34

There are some unit tests that need to use a different check, such as window.opera for jQuery.browser.opera.

Changed June 18, 2012 04:32PM UTC by dmethvin comment:35

resolution: → fixed
status: openclosed

Duly and exhaustively deprecated. The jQuery.browser repo will be merged into the backcompat repo when it's created.