Opened 12 years ago
Closed 11 years ago
#9385 closed enhancement (fixed)
Deprecate jQuery.browser
Reported by: | Owned by: | Rick Waldron | |
---|---|---|---|
Priority: | blocker | Milestone: | 1.8 |
Component: | support | Version: | 1.6.1 |
Keywords: | 1.8-discuss | Cc: | |
Blocked by: | Blocking: |
Description
Add Google Chrome to jQuery.browser, that is all :)
Change History (35)
comment:1 Changed 12 years ago by
Keywords: | 1.7-discuss added |
---|
comment:2 Changed 12 years ago by
-1, Adding new support to jQuery.browser might be perceived as encouragement to use it.
comment:5 Changed 12 years ago by
-1
(While I'm on the Chrome team, this is my personal opinion)
$.browser.safari was renamed to webkit a few versions ago to preempt this request.
comment:6 Changed 12 years ago by
Component: | unfiled → support |
---|---|
Priority: | undecided → low |
Status: | new → open |
comment:7 Changed 12 years ago by
+1, Gentlemen, what are our intentions with respect to jQuery.browser
? If we are going to let it languish then let's just yank it with the reasoning that we aren't maintaining it anyway. The docs say it will be a supported plugin eventually. Will the plugin return Chrome?
comment:10 Changed 12 years ago by
+1, Totally agree with Dave here. If it's there, it should at least be sensible. Otherwise, let's actually get rid of the damn thing.
comment:12 Changed 12 years ago by
+1, sometimes there are browser bugs which are not testable through $.support
comment:13 Changed 12 years ago by
Owner: | set to Rick Waldron |
---|---|
Status: | open → assigned |
comment:14 Changed 12 years ago by
Milestone: | 1.next → 1.7 |
---|---|
Priority: | low → blocker |
comment:15 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Merge pull request #417 from rwldrn/9385
Begrudgingly adds chrome detection to jQuery.browser (1.7). Fixes #9385
Changeset: 5417a2cf6b629b5bf3103454a5a6cab2181924e8
comment:16 Changed 12 years ago by
What about Safari ? Now there's Chrome but no Safari, that's odd/annoying. Perhaps add back safari as well ?
comment:17 Changed 12 years ago by
Revert "Updated version numbers; Fixes #9385"
This reverts commit 09fe3ea265d730cc5e2dd2705d5a60ffd382d166.
Changeset: e2187f49637c62d9b72ec852c9213a20778e63d3
comment:18 Changed 12 years ago by
Revert "Begrudgingly adds chrome detection to jQuery.browser (1.7). Fixes #9385"
This reverts commit dd93d0eb32dc638ff3319792a885acd6d3c25c30.
Changeset: 2a045f8269de9ef936bfaa2efbf71b9962385cf8
comment:20 Changed 12 years ago by
Status: | reopened → open |
---|
comment:21 Changed 12 years ago by
Keywords: | 1.8-discuss added; 1.7-discuss removed |
---|---|
Milestone: | 1.7 → 1.8 |
comment:22 Changed 11 years ago by
+1, If we're going to have a jQuery.browser at all, it should be able to detect Chrome. This vote becomes a -1 if instead we decide to gut jQuery.browser completely.
comment:23 Changed 11 years ago by
-1, Changing to -1 because I just saw that moving jQuery.browser to a compatibility plugin was up for a vote. :-)
comment:24 Changed 11 years ago by
+0, if we move $.browser to an official plugin, then we can have this kind of change. Else, no.
comment:25 Changed 11 years ago by
We voted this down in 1.7 but if we are planning to abandon maintenance of jQuery.browser we should determine a sunset version and get rid of it.
Our current docs say it will be turned into a plugin, I think the community's assumption would be that it is an official and maintained plugin. If we aren't going to maintain this we need to say so ASAP and provide other alternatives to avoid breaking code. (Although if it uses jQuery.browser it's already broken ... ba-dum-pum!)
comment:30 Changed 11 years ago by
OK, we're keeping this in as-is for 1.8 but will trumpet that it is being removed into a plugin as of 1.9. It is already deprecated in the docs.
comment:32 Changed 11 years ago by
Summary: | Add Google Chrome to jQuery.browser → Deprecate jQuery.browser |
---|
There will be a separate plugin as of 1.8, and jQuery.browser
will disappear from core as of 1.9. You can include the plugin as of 1.8 if desired, or substitute your own flaky-and-fragile regex for our flaky-and-fragile regex, or (even better) just stop using browser sniffing.
comment:34 Changed 11 years ago by
There are some unit tests that need to use a different check, such as window.opera
for jQuery.browser.opera
.
comment:35 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | open → closed |
Duly and exhaustively deprecated. The jQuery.browser repo will be merged into the backcompat repo when it's created.
Nominating ticket for 1.7 discussion.