jQuery private data should stay private

[gnarf]

It seems that the "private" data is ALWAYS stored on the .data(jQuery.expando) - For "objects" where the deletion of the object should also delete its caches this makes some sense.

In the realm of nodes however, I think we should store these "private" members in a separate (private) cache so that they don't pollute the object returned by $.fn.data()

[john]

Nominating ticket for 1.7 discussion.

[Rick Waldron]

+0, Duplicates #8792

[jaubourg]

+1, I know the code would probably grow (I'm not so sure but heh) but I think it makes a lot of sense

[Timmy Willison]

-1, use case where this is a problem?

[gnarf]

The reason I ran into the issue in the first place was that I changed the .data() behavior to store a flag in private data stopping it from scanning all the data- attribs more than once. Then a bunch of unit tests broke becuase it was using the jQuery.expando key on the .data() -- Basically, anytime you wanted to for ... in the .data() you're going to need to "ignore" the "private" data....

[dmethvin]

+1, I was thinking the same, worth considering with the "attach data to DOM elements" rewrite if it can be done

[john]

+0, Don't really have strong feelings on this.

[ajpiano]

+1, Seems to be part of fixing #8909

[gnarf]

​https://github.com/jquery/jquery/pull/499

Pull currently closed while I look at another option.

[gnarf]

I think ​https://github.com/jquery/jquery/pull/500 turned out better than 499...

It changes it around so that instead of the "public data cache" storing the "private data" there is a "private data cache" which stores "public data"

[Corey Frang]

Landing pull request 500. 1.7 - "public data" stored as a key on "internal data" - Fixes #8921.

More Details:

• ​https://github.com/jquery/jquery/pull/500
• ​http://bugs.jquery.com/ticket/8921 Changeset: d5f144a7bba98212d6fe9e257f722b62baf651f0