$(':text') should match <input> since `type=text` is the implied default

[mathias]

Test case: ​http://jsfiddle.net/mathias/CpvgM/

Currently, $(':text') only matches inputs with type=text explicitly set. It should also match <input> since type=text is the implied default in all browsers (as per the HTML spec).

[mathias]

For the record, when this is fixed, the docs should probably be updated as well: ​http://api.jquery.com/text-selector/

[mathias]

Here’s a fix: ​https://github.com/jeresig/sizzle/pull/52

[addyosmani]

Thanks. The pull request looks fairly decent - CC'ing snover for further review.

[dmethvin]

We talked about this on -dev today, it seems like a good idea. However we should discourage <input /> in markup since it does not match qSA for input[type=text] -- the attribute is missing, only the property is "text".

[[email protected]…]

It is critical regression for my projects, I did not set type attribute for text input _several years_.

So now I need edit and test tons of HTML/XSL/PHP/JS templates to upgrade to jQuery 1.5.1?

[mathias]

@dmifedorenko: Actually, no. $(':text') should match <input> and it has always worked that way before jQuery 1.5.1 was released. The regression you’re talking about is in 1.5.1, and this patch will fix it.

[dmethvin]

#8163 is a duplicate of this ticket.

[gnarf]

I probably introduced this bug in 1.5.1 - ​https://github.com/gnarf37/sizzle/commit/0048e13aa17bd805374784f7d6e6f6f0a0140fe7 -- Before that commit, :text just did "text" === elem.type -- we could potentially revert that function (not the whole commit since :text is a Sizzle only "magic" selector it can do whatever we need it to.

If you want to override this in 1.5.1 for your own regression purposes its a one line fix:

jQuery.find.selectors.filters['text'] = function(elem) { return "text" === elem.type };

​http://jsfiddle.net/CpvgM/1/

[anonymous]

Wouldn't this work? (to replace line 619 from ​https://github.com/gnarf37/sizzle/commit/0048e13aa17bd805374784f7d6e6f6f0a0140fe7)

return "text" === (elem.getAttribute( 'type' ) || "text");

As it will return the value of type, and if this is null, it will return the default: "text".

[dmethvin]

#8565 is a duplicate of this ticket.

[john]

Landed mathias' pull request.

[danheberden]

Per matjas: [8:29 AM] <matjas> now that #8380 is fixed, the text on ​http://api.jquery.com/text-selector/ needs some tweaking

[addyosmani]

#8583 is a duplicate of this ticket.

[kswedberg]

updated documentation