Skip to main content

Bug Tracker

Side navigation

#8145 closed enhancement (fixed)

Opened February 02, 2011 04:35PM UTC

Closed February 12, 2011 02:56PM UTC

Last modified March 09, 2012 10:04AM UTC

jQuery.readyWait Standalone Test Page

Reported by: rwaldron Owned by: jrburke
Priority: high Milestone: 1.5.1
Component: event Version: 1.5
Keywords: Cc:
Blocked by: Blocking:

Per -dev discussion, James Burke is going to provide us with a standalone test case for the jQuery.readyWait implementation

Attachments (0)
Change History (8)

Changed February 02, 2011 04:35PM UTC by rwaldron comment:1

owner: → jrburke
status: newassigned

Changed February 02, 2011 04:43PM UTC by rwaldron comment:2

blocking: → 8141

Changed February 03, 2011 03:47AM UTC by dmethvin comment:3

Documentation for jQuery.holdReady is here (must be logged in):

Changed February 03, 2011 05:36AM UTC by jrburke comment:4

I just put two commits in my fork and did a pull request, but since I had a previous pull request, it seems to show the commits I did for #7102, some of which were merged but then later reverted. The pull request is here:

but I really just want the last two commits in that pull request for this ticket:

I apologize for my lack of GitHub skills, if someone has a clue on how to fix the pull request, I'm happy to do it. I'm thinking I will just delete my fork and start over fresh, but give a holler if there is a trick to get the existing thing to work.

I tested the readywait.html and readywait2.html with rwaldron's fix mentioned above for #8141 and it works, but just did a cursory test in IE6, Safari 5 and Firefox 4 beta.

Changed February 03, 2011 11:02AM UTC by jitter comment:5

component: unfiledevent
milestone: 1.next1.5.1
priority: undecidedhigh

Hi, thanks for the tests (didn't try them yet) but I guess dave and/or rick will later on.

For your "problems" with the pull request. It basically boils down to the fact that you did all your changes on the "master" branch instead of using a separate branch for separate changes.

This is briefly touched upon in Tips for jQuery Bug Patching. If you need more info on how to: clean up your master branch, resync with jquery-master, make separate branches and pulling over the commits you made to those branches I guess it's easiest if you hit us on irc.

Changed February 03, 2011 05:29PM UTC by rwaldron comment:6

Handing these off to dmethvin to match with his readyWait/readyHold patch

Changed February 03, 2011 05:43PM UTC by jrburke comment:7

jitter: thanks for the pointers, that makes perfect sense, and something I should have looked for before.

rwaldron: thanks for cleaning up my github mess. I'll do better next time.

Changed February 12, 2011 02:56PM UTC by jrburke comment:8

resolution: → fixed
status: assignedclosed

Add readyWait tests. Fixes #8145.

Adds tests for the fix to #6781.

Changeset: d99268a4b728e47d02b9b893e08796c8060a68e9