jQuery.readyWait Standalone Test Page

[Rick Waldron]

Per -dev discussion, James Burke is going to provide us with a standalone test case for the jQuery.readyWait implementation

[Rick Waldron]

(In #8141) Preliminary fix to jQuery.ready()...

​https://github.com/rwldrn/jquery/commit/c29faf374364784348429e9055ffbf3513871c62

[dmethvin]

Documentation for jQuery.holdReady is here (must be logged in): ​http://api.jquery.com/?p=3779&preview=true

[jrburke]

I just put two commits in my fork and did a pull request, but since I had a previous pull request, it seems to show the commits I did for #7102, some of which were merged but then later reverted. The pull request is here:

​https://github.com/jquery/jquery/pull/166

but I really just want the last two commits in that pull request for this ticket:

​https://github.com/jrburke/jquery/commit/4bcd5f81b1af9fc3a489c17125ea1edbbc323c5d

​https://github.com/jrburke/jquery/commit/98112604dc31588bbe9c6f70ed29765b798efdf0

I apologize for my lack of GitHub skills, if someone has a clue on how to fix the pull request, I'm happy to do it. I'm thinking I will just delete my fork and start over fresh, but give a holler if there is a trick to get the existing thing to work.

I tested the readywait.html and readywait2.html with rwaldron's fix mentioned above for #8141 and it works, but just did a cursory test in IE6, Safari 5 and Firefox 4 beta.

[jitter]

Hi, thanks for the tests (didn't try them yet) but I guess dave and/or rick will later on.

For your "problems" with the pull request. It basically boils down to the fact that you did all your changes on the "master" branch instead of using a separate branch for separate changes.

This is briefly touched upon in ​Tips for jQuery Bug Patching. If you need more info on how to: clean up your master branch, resync with jquery-master, make separate branches and pulling over the commits you made to those branches I guess it's easiest if you hit us on irc.

[Rick Waldron]

Handing these off to dmethvin to match with his readyWait/readyHold patch

​https://github.com/jquery/jquery/pull/222

[jrburke]

jitter: thanks for the pointers, that makes perfect sense, and something I should have looked for before.

rwaldron: thanks for cleaning up my github mess. I'll do better next time.

[jrburke]

Add readyWait tests. Fixes #8145.

Adds tests for the fix to #6781.

Changeset: d99268a4b728e47d02b9b893e08796c8060a68e9