#7219 closed bug (fixed)
.children(selector) no longer works in 1.4.3
| Reported by: | anonymous | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.4.4 |
| Component: | selector | Version: | 1.4.3 |
| Keywords: | children regression | Cc: | |
| Blocked by: | Blocking: |
Description
without selector .children() works, but using a selector like "#abc" return an empty object.
Change History (17)
comment:1 follow-ups: 5 17 Changed 12 years ago by
| Keywords: | children added |
|---|---|
| Resolution: | → worksforme |
| Status: | new → closed |
comment:2 Changed 12 years ago by
test case: http://jsfiddle.net/z6XBx/2/ but replacing the first "children" by a "find" and it works.
comment:4 Changed 12 years ago by
just deleting "<instance_node url="#default"/>" and "<instance_camera url="#Home-camera"/>" in the test case html and it works like expected. so it seems the problem comes from here ?
comment:5 follow-up: 6 Changed 12 years ago by
Replying to addyosmani:
This is working fine with both jQuery 1.4.3 and 1.4.2 as per this test case: http://jsfiddle.net/addyosmani/z6XBx/. If you are able to submit a test case which fails using the submitted description we will re-evaluate this ticket.
I work to isolate the problem: see http://jsfiddle.net/z6XBx/5/ in 1.4.2 return 1 in 1.4.3 return 0
comment:6 Changed 12 years ago by
Replying to anonymous:
Replying to addyosmani:
This is working fine with both jQuery 1.4.3 and 1.4.2 as per this test case: http://jsfiddle.net/addyosmani/z6XBx/. If you are able to submit a test case which fails using the submitted description we will re-evaluate this ticket.
I work to isolate the problem: see http://jsfiddle.net/z6XBx/5/ in 1.4.2 return 1 in 1.4.3 return 0
here a clearer test case: http://jsfiddle.net/z6XBx/6/ 1.4.2 return 1 (good) 1.4.3 return 0 (bad)
comment:8 follow-ups: 10 11 Changed 12 years ago by
| Resolution: | worksforme |
|---|---|
| Status: | closed → reopened |
Chrome 6 and Safari 3 fail. All other browsers pass.
comment:9 Changed 12 years ago by
| Component: | unfiled → selector |
|---|---|
| Keywords: | needsreview regression added |
| Priority: | undecided → blocker |
comment:10 Changed 12 years ago by
Replying to snover:
Chrome 6 and Safari 3 fail. All other browsers pass. jQuery doesn’t guarantee support for XML, however, so this may be a
wontfix.
chromium 7.0.517.41 (62167) Ubuntu 10.04 fail too.
comment:11 Changed 12 years ago by
Replying to snover:
Chrome 6 and Safari 3 fail. All other browsers pass. jQuery doesn’t guarantee support for XML, however, so this may be a
wontfix.
'wontfix' would be unfortunate because it worked fine in 1.4.2
comment:12 Changed 12 years ago by
completing test case: http://jsfiddle.net/z6XBx/9/ show that chidren() bug but that find().get(0) works.
comment:13 Changed 12 years ago by
| Owner: | set to dmethvin |
|---|---|
| Status: | reopened → assigned |
comment:15 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Make sure that we don't use matchesSelector on XML Documents (same as with qSA). Fixes #7219.
Changeset: 6bc30425f6d3c9c1eaddacc5d08bb29a4a0636ca
comment:16 Changed 12 years ago by
| Keywords: | needsreview removed |
|---|
comment:17 Changed 11 years ago by
Replying to addyosmani:
This is working fine with both jQuery 1.4.3 and 1.4.2 as per this test case: http://jsfiddle.net/addyosmani/z6XBx/. If you are able to submit a test case which fails using the submitted description we will re-evaluate this ticket.
I create a test at http://jsfiddle.net/z4Jqy/1/
This is working fine with both jQuery 1.4.3 and 1.4.2 as per this test case: http://jsfiddle.net/addyosmani/z6XBx/. If you are able to submit a test case which fails using the submitted description we will re-evaluate this ticket.