Side navigation
#7219 closed bug (fixed)
Opened October 16, 2010 09:50PM UTC
Closed October 22, 2010 04:40AM UTC
Last modified March 19, 2012 09:38AM UTC
.children(selector) no longer works in 1.4.3
| Reported by: | anonymous | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.4.4 |
| Component: | selector | Version: | 1.4.3 |
| Keywords: | children regression | Cc: | |
| Blocked by: | Blocking: |
Description
without selector .children() works, but using a selector like "#abc" return an empty object.
Attachments (0)
Change History (17)
Changed October 16, 2010 10:04PM UTC by comment:1
| keywords: | → children |
|---|---|
| resolution: | → worksforme |
| status: | new → closed |
Changed October 17, 2010 08:24AM UTC by comment:2
Changed October 17, 2010 08:37AM UTC by comment:3
delete "node" tags in html and the test case works.
Changed October 17, 2010 08:46AM UTC by comment:4
just deleting "<instance_node url="#default"/>" and "<instance_camera url="#Home-camera"/>" in the test case html and it works like expected.
so it seems the problem comes from here ?
Changed October 17, 2010 01:19PM UTC by comment:5
Replying to [comment:1 addyosmani]:
This is working fine with both jQuery 1.4.3 and 1.4.2 as per this test case: http://jsfiddle.net/addyosmani/z6XBx/. If you are able to submit a test case which fails using the submitted description we will re-evaluate this ticket.
I work to isolate the problem:
see http://jsfiddle.net/z6XBx/5/
in 1.4.2 return 1
in 1.4.3 return 0
Changed October 18, 2010 07:42PM UTC by comment:6
Replying to [comment:5 anonymous]:
Replying to [comment:1 addyosmani]: > This is working fine with both jQuery 1.4.3 and 1.4.2 as per this test case: http://jsfiddle.net/addyosmani/z6XBx/. If you are able to submit a test case which fails using the submitted description we will re-evaluate this ticket. I work to isolate the problem: see http://jsfiddle.net/z6XBx/5/ in 1.4.2 return 1 in 1.4.3 return 0
here a clearer test case: http://jsfiddle.net/z6XBx/6/
1.4.2 return 1 (good)
1.4.3 return 0 (bad)
Changed October 19, 2010 07:16PM UTC by comment:8
| _comment0: | Chrome 6 and Safari 3 fail. All other browsers pass. → 1287515778031161 |
|---|---|
| resolution: | worksforme |
| status: | closed → reopened |
Chrome 6 and Safari 3 fail. All other browsers pass. jQuery doesn’t guarantee support for XML, however, so this may be a wontfix.
Changed October 19, 2010 07:17PM UTC by comment:9
| component: | unfiled → selector |
|---|---|
| keywords: | children → children needsreview regression |
| priority: | undecided → blocker |
Changed October 19, 2010 07:22PM UTC by comment:10
Replying to [comment:8 snover]:
Chrome 6 and Safari 3 fail. All other browsers pass. jQuery doesn’t guarantee support for XML, however, so this may be a wontfix.chromium 7.0.517.41 (62167) Ubuntu 10.04 fail too.
Changed October 19, 2010 07:34PM UTC by comment:11
Replying to [comment:8 snover]:
Chrome 6 and Safari 3 fail. All other browsers pass. jQuery doesn’t guarantee support for XML, however, so this may be a wontfix.'wontfix' would be unfortunate because it worked fine in 1.4.2
Changed October 20, 2010 07:22PM UTC by comment:12
completing test case: http://jsfiddle.net/z6XBx/9/
show that chidren() bug but that find().get(0) works.
Changed October 22, 2010 12:43AM UTC by comment:13
| owner: | → dmethvin |
|---|---|
| status: | reopened → assigned |
Changed October 22, 2010 03:54AM UTC by comment:14
Simpler test case: http://jsfiddle.net/scvza/
Changed October 22, 2010 04:40AM UTC by comment:15
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Make sure that we don't use matchesSelector on XML Documents (same as with qSA). Fixes #7219.
Changeset: 6bc30425f6d3c9c1eaddacc5d08bb29a4a0636ca
Changed November 02, 2010 02:17AM UTC by comment:16
| keywords: | children needsreview regression → children regression |
|---|
Changed March 19, 2012 09:38AM UTC by comment:17
Replying to [comment:1 addyosmani]:
This is working fine with both jQuery 1.4.3 and 1.4.2 as per this test case: http://jsfiddle.net/addyosmani/z6XBx/. If you are able to submit a test case which fails using the submitted description we will re-evaluate this ticket.
I create a test at http://jsfiddle.net/z4Jqy/1/
This is working fine with both jQuery 1.4.3 and 1.4.2 as per this test case: http://jsfiddle.net/addyosmani/z6XBx/. If you are able to submit a test case which fails using the submitted description we will re-evaluate this ticket.