Bug Tracker

Opened 8 years ago

Closed 7 years ago

#5812 closed enhancement (wontfix)

Should look for =%3F in addition to =?

Reported by: harrisms Owned by: Rick Waldron
Priority: low Milestone: 1.5
Component: ajax Version: 1.4
Keywords: ajaxrewrite Cc:
Blocked by: #8054 Blocking:

Description

The ajax function searches for =? in the data string to replace it with =jsonp..., but it does that *after* the data string is constructed by the param function, which uses encodeURIComponent to turn =? into =%F.

A quick fix is to modify the jsre regex to match =%3F too.

Change History (6)

comment:1 Changed 7 years ago by Rick Waldron

Milestone: 1.4.11.5
Owner: set to Rick Waldron
Priority: minorlow
Status: newassigned
Type: bugenhancement

comment:2 Changed 7 years ago by Rick Waldron

Keywords: ajaxrewrite added

comment:3 Changed 7 years ago by jaubourg

Resolution: fixed
Status: assignedclosed

Fixes #5812. =? will be detected even when it has been escaped during data serialization.

Changeset: 8c8bd3bf6ac982f98c1b89b0af74a1fd2d07e360

comment:4 Changed 7 years ago by jaubourg

#4920 is a duplicate of this ticket.

comment:5 Changed 7 years ago by jaubourg

Resolution: fixed
Status: closedreopened

comment:6 Changed 7 years ago by jaubourg

Blocked by: 8054 added
Resolution: wontfix
Status: reopenedclosed

This enhancement breaks legitimate uses of ? in url or data. The fix was reverted here 325dcdc

Last edited 7 years ago by jitter (previous) (diff)
Note: See TracTickets for help on using tickets.