jQuery.browser.version can be incorrect with mutant IE userAgent strings

Reported by:	dbergey	Owned by:	flesler
Priority:	major	Milestone:	1.3
Component:	core	Version:	1.2.6
Keywords:	browser version msie	Cc:
Blocked by:		Blocking:

Description

jquery.browser.version currently looks at the last match of /ie ([\\d.]+)/ .. it should look for all matches, then use the highest found version. In some situations IE 7 will present itself as both IE 7.0 and IE 6.0 for compatibility, and sometimes the declarations get out of order, not to mention adware and toolbars messing with the registry (see: http://jamazon.co.uk/web/2008/07/23/an-ie7-bug-that-returns-msie-60-user-agent-string/). The attached patch supplements the existing userAgent checking, but could be improved upon.

Attachments (2)

ieversion.patch (0.4 KB) - added by dbergey September 23, 2008 04:42PM UTC.
ieversion2.patch (0.2 KB) - added by dbergey September 24, 2008 05:14PM UTC.

Updated patch (fewer lines, future-proofed)

Change History (4)

Changed September 23, 2008 10:49PM UTC by flesler comment:1

owner:	→ flesler
status:	new → assigned

There were already more than 1 tickets for this, with no 100% successful patch.

I'll keep this ticket in mind for when we handle this.

Changed September 24, 2008 05:12PM UTC by dbergey comment:2

Updated patch to be IE-version-agnostic, and reduced from 7 to 2 lines.

Changed January 15, 2009 04:41AM UTC by dmethvin comment:3

Tickets #3696, #3402, #2661, and #2413 are all related, but for different user-agents.

Changed March 18, 2009 03:04AM UTC by brandon comment:4

resolution:	→ duplicate
status:	assigned → closed

duplicate of #2661

Side navigation