Side navigation
#13483 closed bug (fixed)
Opened February 20, 2013 01:11PM UTC
Closed April 17, 2013 03:15AM UTC
Issue with stop(true).slideDown() during slideUp()
| Reported by: | styu | Owned by: | ros3cin |
|---|---|---|---|
| Priority: | high | Milestone: | None |
| Component: | effects | Version: | 1.9.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
The issue is when the submenu is in the sliding up state, and it is clicked again, it stops but is not being animated backwards (instead the submenus are jumping out but their container is keeping its current height - no jump with jquery 2.0.0.b1). Tested in Firefox and Chrome with the same result.
Attachments (0)
Change History (12)
Changed February 20, 2013 05:51PM UTC by comment:1
Changed March 05, 2013 12:36AM UTC by comment:2
I'm trying to check this issue. \\o
Changed March 08, 2013 02:52AM UTC by comment:3
| _comment0: | Your issue is indeed a bug. After you stop a slideUp() animation before it finish, and try to do a slideDown(), it won't go. I am looking into this problem, trying to figure out where is the error. I really wanna contribute to this. I started debuging on sunday. \ → 1362713425049036 |
|---|
Your issue is indeed a bug. After you stop a slideUp() animation before it finish, and try to do a slideDown(), it won't go. I am looking into this problem, trying to figure out where is the error. I really wanna contribute to this. I started debuging on sunday.
I'm putting here another test case, more clean to understand, ok. http://jsfiddle.net/rgkv8/5/
Changed March 08, 2013 03:56PM UTC by comment:4
I have an other issue with sliding in IE10, maybe related to this one, but I can't make a simplified test case yet. Basically the styles added by slideUp() remains on the element after it seems to be completely hidden, and the on complete event never fires. But this seems to be an issue in IE10 only. My workaround is to use only show() and hide() in IE10 instead of slideDown() and slideUp().
Changed March 09, 2013 09:24PM UTC by comment:5
Hey, styu!
I made progress fixing the bug! But it is still in partial resolution.
I'm working hard to get the issue done ( respectiong jQuery standards ), as soon as possible.
Changed March 13, 2013 01:23AM UTC by comment:6
| component: | unfiled → effects |
|---|---|
| priority: | undecided → high |
| status: | new → open |
Changed March 13, 2013 02:58AM UTC by comment:7
| _comment0: | timmywil, would you assign this one to me? \ I'll be sending a patch for you to check this week. \ \ Also, the reason the submenus are jumping is due to this fix http://bugs.jquery.com/ticket/12846. \ When you stop the animation, the overflow attribute will be set to normal, causing the submenu to appear over other itens. \ I guess this makes another issue to correct. → 1363143538469641 |
|---|---|
| _comment1: | timmywil, would you assign this one to me? \ I'll be sending a patch for you to check this week. \ \ Also, the reason the submenus are jumping is due to this fix http://bugs.jquery.com/ticket/12846. \ When you stop the animation, the overflow attribute will be set to normal, causing the submenu to appear over other itens. \ I guess this makes another issue to fix. → 1363143593404869 |
timmywil, would you assign this one to me?
I'll be sending a patch for you to check this week.
Also, the reason the submenus are jumping is due to this fix http://bugs.jquery.com/ticket/12846.
When you stop the animation, the overflow attribute will be set to normal, causing the submenu to appear over other itens, it should stay as overflow hidden.
I guess this makes another issue to fix.
Changed March 13, 2013 05:38PM UTC by comment:8
| owner: | → ros3cin |
|---|---|
| status: | open → assigned |
Changed March 14, 2013 03:21AM UTC by comment:9
| _comment0: | I'm just writing test → 1363231840169030 |
|---|
I'm writing test
Changed March 17, 2013 07:13AM UTC by comment:10
Hey, styu!
I've made the fix and asked the oficial jQuery to update with it.
But I can already provide you jQuery with the changes I made.
http://speedy.sh/6nySn/jquery.js
*If I'm not allowed to provide this link here, tell me, timmywil*
Changed April 05, 2013 01:43AM UTC by comment:11
#13370 is a duplicate of this ticket.
Changed April 17, 2013 03:15AM UTC by comment:12
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Fix #13483. Let slideDown() work after stop(). Close gh-1205.
Changeset: ea5c22ec12e6a548b1ec2d7b0dcd9f71bea8d5dd
There is a workaround for this issue, just need to call .hide() before calling .stop(true).slideDown(). But I still think that this is an issue and needs to be solved internally.
Working example (thanks for Brad M):
http://jsfiddle.net/HuCmy/37/