Opened 12 years ago
Closed 11 years ago
#10870 closed bug (fixed)
Incorrect behaviour of $.removeAttr("selected")
Reported by: | Owned by: | Timmy Willison | |
---|---|---|---|
Priority: | high | Milestone: | 1.7.2 |
Component: | attributes | Version: | 1.7 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
Calling $.removeAttr("selected") on the option that doesn't have "selected" attribute, changes the selection. Example: http://jsfiddle.net/HHDpK/1/
Based on http://stackoverflow.com/questions/8226702/jquery-removeattrselected-changes-selected-option
Change History (10)
comment:1 Changed 12 years ago by
Component: | unfiled → attributes |
---|---|
Priority: | undecided → low |
Resolution: | → worksforme |
Status: | new → closed |
comment:2 Changed 12 years ago by
Do I understand you correctly that $.removeAttr() is not backward compatible since 1.6? Sure I'm going to use $.prop() in a new code, but there is plenty already written.
comment:3 Changed 12 years ago by
Resolution: | worksforme |
---|---|
Status: | closed → reopened |
Do NOT remove native properties with .removeProp. They cannot be recreated. Instead, we recommend:
$elems.prop('selected', false); $elems.prop('selected', true);
Anyway, with the boolHook, this should be working. In removeAttr, we are setting attributes to empty string before removal. Unfortunately, the mere presence of a boolean attribute indicates true for the property and sets all other options' selected properties to false, and then removes it.
comment:4 Changed 12 years ago by
Milestone: | None → 1.7.2 |
---|---|
Owner: | set to Timmy Willison |
Status: | reopened → assigned |
comment:8 Changed 11 years ago by
Priority: | low → high |
---|
comment:10 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Do not set boolean attributes to empty string on removal. Fixes #10870. +0 bytes compressed
Changeset: d3320462df1253196e61b2daadc3cdfe1b4c3771
Thanks for submitting a ticket to the jQuery bug tracker. Please note that switching over to using .prop() for such cases (and .removeProp()) or the property removal should solve the problem you're running into. See here (jsFiddle from the answer on your SO post): http://jsfiddle.net/HHDpK/3/.