Skip to main content

Bug Tracker

Side navigation

#10670 closed bug (fixed)

Opened November 04, 2011 02:41PM UTC

Closed November 08, 2011 02:25AM UTC

Last modified March 08, 2012 08:42PM UTC

rnoshimcache probably not constructed correctly

Reported by: anonymous Owned by: rwaldron
Priority: high Milestone: 1.7.1
Component: manipulation Version: git
Keywords: Cc:
Blocked by: Blocking:

Although this doesn't directly break anything (as far as I know), I would like to mention the following:

rnoshimcache is constructed with the following code:

rnoshimcache = new RegExp("<(?:" + nodeNames.replace(" ", "|") + ")", "i"),

But this only replaces one space with a |. As a result, rnoshimcache is:

/<(?:abbr|article aside audio canvas datalist details figcaption figure footer header hgroup mark meter nav output progress section summary time video)/i

This does not make much sense since it allows for either "abbr" or "all other elements with spaces in between".

I think all spaces should be replaced like:

rnoshimcache = new RegExp("<(?:" + nodeNames.replace(/ /g, "|") + ")", "i"),
Attachments (0)
Change History (5)

Changed November 04, 2011 02:53PM UTC by dmethvin comment:1

resolution: → duplicate
status: newclosed

I think that explains #10667 so I'll close this one as a dup. Many thanks for figuring this out!

Changed November 04, 2011 02:53PM UTC by dmethvin comment:2

Duplicate of #10667.

Changed November 04, 2011 03:54PM UTC by timmywil comment:3

component: unfiledmanipulation
milestone: None1.7.1
priority: undecidedhigh
resolution: duplicate
status: closedreopened

These are not dupes. rwaldron has pending fixes for this issue tho.

Changed November 04, 2011 03:54PM UTC by timmywil comment:4

owner: → rwaldron
status: reopenedassigned

Changed November 08, 2011 02:25AM UTC by Rick Waldron comment:5

resolution: → fixed
status: assignedclosed

Fix busted rnoshimcache. Correctly clone detached unknown elems. Fixes #10667, #10670.

  • \\s => |, Removes 4 bytes from gzipped build
  • Adds tests for clone attributes, children and events

Changeset: 66e65c81684e314448620822c0ba93d9d8c523cd