#10667 closed bug (fixed)

Opened November 04, 2011 02:01PM UTC

Closed November 08, 2011 02:25AM UTC

Last modified March 08, 2012 08:37PM UTC

HTML5 Support in .wrapAll() does add a ":" to element

Reported by:	t.fellinger@netzgestaltung.at	Owned by:	t.fellinger@netzgestaltung.at
Priority:	blocker	Milestone:	1.7.1
Component:	manipulation	Version:	1.7
Keywords:		Cc:
Blocked by:		Blocking:

Description

Hi there - im testing the HTML5 support for adding some content in IE 8

$('#content section.content').clone()

.find('h2')

.prependTo('#content section.content')

.wrapAll('<aside class="sidebar"></aside>');

leads to <:aside class="sidebar"><h2>...</h2>

jsFiddle:[http://jsfiddle.net/hkRaK/1/ take a look at it on IE 8]

Attachments (0)

Change History (11)

Changed November 04, 2011 02:11PM UTC by rwaldron comment:1

component:	unfiled → manipulation
milestone:	None → 1.7.1
owner:	→ rwaldron
priority:	undecided → blocker
status:	new → assigned

Changed November 04, 2011 02:23PM UTC by rwaldron comment:2

owner:	rwaldron → t.fellinger@netzgestaltung.at
status:	assigned → pending

I'm not able to reproduce this - how are you testing and/or observing this issue?

Changed November 04, 2011 02:40PM UTC by dmethvin comment:3

status:	pending → open

I can see it in the html view from F12 Developer Tools.

http://gyazo.com/776ee2f77dccdec42ff077a20c6c4772

Changed November 04, 2011 02:52PM UTC by dmethvin comment:4

Ah! See #10670 I think that explains it.

Changed November 04, 2011 02:53PM UTC by dmethvin comment:5

#10670 is a duplicate of this ticket.

Changed November 04, 2011 03:04PM UTC by timmywil comment:6

reduced test case: http://jsfiddle.net/timmywil/hkRaK/3/

Changed November 04, 2011 03:05PM UTC by timmywil comment:7

reduced further: http://jsfiddle.net/timmywil/hkRaK/4/

Changed November 04, 2011 03:57PM UTC by timmywil comment:8

So, I propose we do something similar to the newCloneNode function in http://www.iecss.com/shimprove/javascript/shimprove.1-0-1.js, but with the html5-safe fragment that we have and only for html5 elements. elem.cloneNode( true ) is not sufficient for initial creation.

There are a couple different codepaths I'm envisioning. We should keep in mind that using cloneNode and then attaching it to the safeFragment also fixes it.

http://jsfiddle.net/timmywil/hkRaK/11/

Changed November 08, 2011 02:25AM UTC by Rick Waldron comment:9

resolution:	→ fixed
status:	open → closed

Fix busted rnoshimcache. Correctly clone detached unknown elems. Fixes #10667, #10670.

\\s => |, Removes 4 bytes from gzipped build

Adds tests for clone attributes, children and events

Changeset: 66e65c81684e314448620822c0ba93d9d8c523cd

Changed November 08, 2011 11:05AM UTC by t.fellinger@netzgestaltung.at comment:10

Thanks for that, how can i test it?

greets

tom

Changed November 08, 2011 01:52PM UTC by rwaldron comment:11

@tom - the patch has landed and will be included in the 1.7.1 bug-fix release

Side navigation