Bug Tracker

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#10670 closed bug (fixed)

rnoshimcache probably not constructed correctly

Reported by: anonymous Owned by: Rick Waldron
Priority: high Milestone: 1.7.1
Component: manipulation Version: git
Keywords: Cc:
Blocked by: Blocking:


Although this doesn't directly break anything (as far as I know), I would like to mention the following:

rnoshimcache is constructed with the following code:

rnoshimcache = new RegExp("<(?:" + nodeNames.replace(" ", "|") + ")", "i"),

But this only replaces one space with a |. As a result, rnoshimcache is:

/<(?:abbr|article aside audio canvas datalist details figcaption figure footer header hgroup mark meter nav output progress section summary time video)/i

This does not make much sense since it allows for either "abbr" or "all other elements with spaces in between".

I think all spaces should be replaced like:

rnoshimcache = new RegExp("<(?:" + nodeNames.replace(/ /g, "|") + ")", "i"),

Change History (5)

comment:1 Changed 12 years ago by dmethvin

Resolution: duplicate
Status: newclosed

I think that explains #10667 so I'll close this one as a dup. Many thanks for figuring this out!

comment:2 Changed 12 years ago by dmethvin

Duplicate of #10667.

comment:3 Changed 12 years ago by Timmy Willison

Component: unfiledmanipulation
Milestone: None1.7.1
Priority: undecidedhigh
Resolution: duplicate
Status: closedreopened

These are not dupes. rwaldron has pending fixes for this issue tho.

comment:4 Changed 12 years ago by Timmy Willison

Owner: set to Rick Waldron
Status: reopenedassigned

comment:5 Changed 12 years ago by Rick Waldron

Resolution: fixed
Status: assignedclosed

Fix busted rnoshimcache. Correctly clone detached unknown elems. Fixes #10667, #10670.

  • \s => |, Removes 4 bytes from gzipped build
Note: See TracTickets for help on using tickets.