rnoshimcache probably not constructed correctly

[anonymous]

Although this doesn't directly break anything (as far as I know), I would like to mention the following:

rnoshimcache is constructed with the following code:

rnoshimcache = new RegExp("<(?:" + nodeNames.replace(" ", "|") + ")", "i"),

But this only replaces one space with a |. As a result, rnoshimcache is:

/<(?:abbr|article aside audio canvas datalist details figcaption figure footer header hgroup mark meter nav output progress section summary time video)/i

This does not make much sense since it allows for either "abbr" or "all other elements with spaces in between".

I think all spaces should be replaced like:

rnoshimcache = new RegExp("<(?:" + nodeNames.replace(/ /g, "|") + ")", "i"),

[dmethvin]

I think that explains #10667 so I'll close this one as a dup. Many thanks for figuring this out!

[dmethvin]

Duplicate of #10667.

[Timmy Willison]

These are not dupes. rwaldron has pending fixes for this issue tho.

[Rick Waldron]

Fix busted rnoshimcache. Correctly clone detached unknown elems. Fixes #10667, #10670.

• \s => |, Removes 4 bytes from gzipped build

• Adds tests for clone attributes, children and events Changeset: 66e65c81684e314448620822c0ba93d9d8c523cd