Side navigation
#10670 closed bug (fixed)
Opened November 04, 2011 02:41PM UTC
Closed November 08, 2011 02:25AM UTC
Last modified March 08, 2012 08:42PM UTC
rnoshimcache probably not constructed correctly
| Reported by: | anonymous | Owned by: | rwaldron |
|---|---|---|---|
| Priority: | high | Milestone: | 1.7.1 |
| Component: | manipulation | Version: | git |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Although this doesn't directly break anything (as far as I know), I would like to mention the following:
rnoshimcache is constructed with the following code:
rnoshimcache = new RegExp("<(?:" + nodeNames.replace(" ", "|") + ")", "i"),
But this only replaces one space with a |. As a result, rnoshimcache is:
/<(?:abbr|article aside audio canvas datalist details figcaption figure footer header hgroup mark meter nav output progress section summary time video)/i
This does not make much sense since it allows for either "abbr" or "all other elements with spaces in between".
I think all spaces should be replaced like:
rnoshimcache = new RegExp("<(?:" + nodeNames.replace(/ /g, "|") + ")", "i"),
Attachments (0)
Change History (5)
Changed November 04, 2011 02:53PM UTC by comment:1
| resolution: | → duplicate |
|---|---|
| status: | new → closed |
Changed November 04, 2011 03:54PM UTC by comment:3
| component: | unfiled → manipulation |
|---|---|
| milestone: | None → 1.7.1 |
| priority: | undecided → high |
| resolution: | duplicate |
| status: | closed → reopened |
These are not dupes. rwaldron has pending fixes for this issue tho.
Changed November 04, 2011 03:54PM UTC by comment:4
| owner: | → rwaldron |
|---|---|
| status: | reopened → assigned |
I think that explains #10667 so I'll close this one as a dup. Many thanks for figuring this out!