Skip to main content

Bug Tracker

Side navigation

#10006 closed bug (fixed)

Opened August 09, 2011 01:57AM UTC

Closed January 13, 2012 12:57AM UTC

Last modified August 14, 2012 12:30PM UTC

method show is not working as expected in all browsers when called for document fragment

Reported by: markel Owned by: rwaldron
Priority: high Milestone: 1.7.2
Component: effects Version: 1.6.2
Keywords: Cc:
Blocked by: Blocking:

When html generated from template (or something like that), sometimes need to call method "show" to not attached elements and then append them. In contrast with method "hide", "show" is not working in this case, except for Mozilla all others browsers do not set style attribute.

Of course it's very easy to fix with setting display property manually, but it's not very easy to understand when you have this kind of inconstancy.

test case:

Attachments (0)
Change History (12)

Changed August 09, 2011 01:36PM UTC by timmywil comment:1

component: unfiledeffects
priority: undecidedlow
status: newopen

We may be able to just add a check to see if the node is connected.

Third party pull request

Changed November 06, 2011 04:12PM UTC by rwaldron comment:2

milestone: 1.next1.7.1
owner: → mikesherov
priority: lowhigh
status: openassigned

Changed November 06, 2011 04:12PM UTC by rwaldron comment:3

#10695 is a duplicate of this ticket.

Changed November 06, 2011 04:15PM UTC by rwaldron comment:4

owner: mikesherovrwaldron

Whoops, didn't mean to assign @mikesherov to this, that was an accident

Changed November 06, 2011 04:59PM UTC by rwaldron comment:5

I cleaned up Orkel's patch and made a fresh PR:

Changed November 21, 2011 06:27PM UTC by Rick Waldron comment:6

resolution: → fixed
status: assignedclosed

Landing pull request 581. Updates original patch by Orkel. Fixes #10006.

More Details:

Changeset: 299bc655c90cc89652417675f976ae1bfefc4d8b

Changed November 22, 2011 02:00AM UTC by Dave Methvin comment:7

Revert "Landing pull request 581. Updates original patch by Orkel. Fixes #10006."

This reverts commit 299bc655c90cc89652417675f976ae1bfefc4d8b.

Changeset: 3586ea28a8303a8de9f7f94da9fe9c4272b3d8ec

Changed November 22, 2011 02:02AM UTC by dmethvin comment:8

resolution: fixed
status: closedreopened

This patch was causing a memory leak only in Testswarm so we backed it out. Yeah, I don't understand it either.

Changed November 22, 2011 02:02AM UTC by dmethvin comment:9

status: reopenedopen

Changed January 13, 2012 12:43AM UTC by dmethvin comment:10

milestone: 1.next1.7.2

Changed January 13, 2012 12:57AM UTC by Oleg comment:11

resolution: → fixed
status: openclosed

Fix #10006: Allow .show() to work on detached elements.

Changeset: cc5e8e3866e5dac7eacda5927679573c8da79492

Changed August 14, 2012 12:30PM UTC by anonymous comment:12

It seems like this was added in rather than removed. I'm seeing this bug after having updated to v1.7.2 from v1.4.4, but only in Chrome.