Bug Tracker

Modify ↓

Ticket #6997 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

before and after do not clone events data properly

Reported by: israelrios Owned by: john
Priority: blocker Milestone: 1.5
Component: manipulation Version: 1.4.2
Keywords: before clone Cc:
Blocking: Blocked by:

Description

The documentation says insertBefore() and before() behavior is similar but with params and object inverted. But, when clones are made of the inserted element this isn't true. The insertBefore() clone the element's events and data, but before() does not.

Change History

comment:1 Changed 3 years ago by snover

  • Owner set to israelrios
  • Priority set to undecided
  • Status changed from new to pending
  • Milestone 1.4.2 deleted

Please provide a test case demonstrating this issue.

comment:2 Changed 3 years ago by israelrios

  • Status changed from pending to new

I created a test case:

 http://jsfiddle.net/AcepV/4/

comment:3 Changed 3 years ago by snover

  • Priority changed from undecided to blocker
  • Status changed from new to open
  • Milestone set to 1.next

comment:4 Changed 3 years ago by snover

  • Summary changed from insertBefore() and before() clone behavior differ to before and after do not clone events data properly

comment:5 Changed 3 years ago by snover

  • Milestone changed from 1.4.4 to 1.4.5

Retargeting due to severity of 1.4.3 regressions.

comment:6 Changed 3 years ago by snover

  • Milestone changed from 1.4.5 to 1.4.4

Retargeting for 1.4.4 as per John’s request.

comment:7 Changed 3 years ago by john

  • Owner changed from israelrios to john
  • Status changed from open to assigned

comment:8 Changed 3 years ago by snover

  • Milestone changed from 1.4.4 to 1.4.5

Retargeting to next minor release.

comment:9 Changed 3 years ago by snover

  • Status changed from assigned to closed
  • Resolution set to duplicate

comment:10 Changed 3 years ago by snover

Duplicate of #5566.

comment:11 Changed 3 years ago by Colin Snover

  • Resolution changed from duplicate to fixed

Merge branch 'bug5566' into csnover-bug5566. Fixes #4386, #5566, #6997.

Conflicts:

src/manipulation.js test/unit/manipulation.js

Changeset: 4fae75d575b20d887e4a273c7991c55f8821a62c

comment:7 Changed 2 years ago by jitter

  • Milestone changed from 1.4.5 to 1.5

Move fixed tickets to appropriate milestone

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.