Skip to main content

Bug Tracker

Side navigation

#6997 closed bug (fixed)

Opened September 03, 2010 01:01PM UTC

Closed December 04, 2010 06:12AM UTC

Last modified December 12, 2010 07:51PM UTC

before and after do not clone events data properly

Reported by: israelrios Owned by: john
Priority: blocker Milestone: 1.5
Component: manipulation Version: 1.4.2
Keywords: before clone Cc:
Blocked by: Blocking:
Description

The documentation says insertBefore() and before() behavior is similar but with params and object inverted. But, when clones are made of the inserted element this isn't true.

The insertBefore() clone the element's events and data, but before() does not.

Attachments (0)
Change History (12)

Changed October 15, 2010 02:27AM UTC by snover comment:1

milestone: 1.4.2
owner: → israelrios
priority: → undecided
status: newpending

Please provide a test case demonstrating this issue.

Changed October 15, 2010 12:16PM UTC by israelrios comment:2

status: pendingnew

I created a test case:

http://jsfiddle.net/AcepV/4/

Changed October 15, 2010 05:23PM UTC by snover comment:3

milestone: → 1.next
priority: undecidedblocker
status: newopen

Changed October 15, 2010 05:29PM UTC by snover comment:4

summary: insertBefore() and before() clone behavior differbefore and after do not clone events data properly

Changed October 21, 2010 10:56PM UTC by snover comment:5

milestone: 1.4.41.4.5

Retargeting due to severity of 1.4.3 regressions.

Changed October 22, 2010 05:53AM UTC by snover comment:6

milestone: 1.4.51.4.4

Retargeting for 1.4.4 as per John’s request.

Changed October 23, 2010 07:18PM UTC by john comment:7

owner: israelriosjohn
status: openassigned

Changed October 28, 2010 02:09AM UTC by snover comment:8

milestone: 1.4.41.4.5

Retargeting to next minor release.

Changed December 04, 2010 06:12AM UTC by snover comment:9

resolution: → duplicate
status: assignedclosed

Changed December 04, 2010 06:12AM UTC by snover comment:10

Duplicate of #5566.

Changed December 12, 2010 07:51PM UTC by Colin Snover comment:11

resolution: duplicatefixed

Merge branch 'bug5566' into csnover-bug5566. Fixes #4386, #5566, #6997.

Conflicts:

src/manipulation.js

test/unit/manipulation.js

Changeset: 4fae75d575b20d887e4a273c7991c55f8821a62c

Changed January 14, 2011 10:20PM UTC by jitter comment:12

milestone: 1.4.51.5

Move fixed tickets to appropriate milestone