Side navigation
#6180 closed bug (fixed)
Opened February 26, 2010 01:43PM UTC
Closed April 12, 2011 08:40PM UTC
Last modified March 09, 2012 02:52PM UTC
jQuery.clean should not touch script tags that are not of type text/javascript
Reported by: | rio | Owned by: | rjgotten |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | manipulation | Version: | 1.5 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
At the very end of the clean function script tag nodes embedded in the nodes stored in the ret array are spliced into the ret array itself.
The clean function should not touch those scripts with a type different from "text/javascript" (e.g. custom types used for script island metadata). This check is partially in place, but still missing from:
ret.splice.apply(ret, [i + 1, 0].concat(jQuery.makeArray(ret[i].getElementsByTagName("script"))) );
The direct use of getElementsByTagName() causes all non-"text/javascript" script tags to be moved to direct children of fragment. If this is combined with temporary container nodes (e.g. the Blind effect in jQuery UI) this causes those script tags to be 'eaten'.
A simple fix is $.grep()-ing the result from getElementsByTagName and only retaining those script elements with the "text/javascript" type.
Attachments (0)
Change History (11)
Changed October 17, 2010 03:50PM UTC by comment:1
Changed October 18, 2010 10:21PM UTC by comment:2
milestone: | 1.4.2 → 1.5 |
---|---|
priority: | → high |
status: | new → open |
version: | 1.4.1 → 1.4.3 |
Changed November 21, 2010 11:01PM UTC by comment:3
3rd party pull request
Changed February 05, 2011 01:02AM UTC by comment:7
Changed April 12, 2011 08:40PM UTC by comment:10
resolution: | → fixed |
---|---|
status: | assigned → closed |
Merge branch 'master' of https://github.com/rjgotten/jquery into rjgotten-master. Also added in unit tests covering the case. Fixes #6180.
Conflicts:
src/manipulation.js
Changeset: 3418f323876043db63a2da9f653e51d5458647fa
Changed April 12, 2011 08:40PM UTC by comment:11
milestone: | 1.next → 1.6 |
---|
Created a jsFiddle which demonstrates the problem present in jQuery 1.4.3: http://jsfiddle.net/3S8Kx/
And created a patch to manipulation.js:
http://github.com/rjgotten/jquery/commit/df7dfc2404807dce2f97c21782eb3a14ced86d6b