Append function not working for parent nodes that are nodeType === 9

[[email protected]…]

I encountered this problem while I was trying to replace the root node of an xml with another one. I was using replaceWith which in this case first removes the old one and then appends the new one to the xml document.

This works id the parent of the node to be replaced is not the XMLDocument (nodeType===9) itself (works for normal element nodes).

I made an test jfiddle for this case: ​http://jsfiddle.net/FranPregernik/ZVMeq

The fix is in the test code. You can enable it by uncommenting the append function. Then both tests will pass.

I can't seem to find if this behavior is desired or was the nodeType === 9 just accidentally neglected.

[[email protected]…]

Tested on: Chrome 13, Firefox 5, IE9

[dmethvin]

I think this wasn't found before because in an HTML document it would be unusual to append elements to the document element. Seems valid for XML though and your patch should do the trick. Many thanks for the clear test case!

[dmethvin]

A couple of notes: 1) The test case throws an error in IE7 for the second test. 2) The xml() helper could be replaced with $.parseXML() now but it's fine as-is.

[FranPregernik]

Update: removed the xml helper and using parseXml at ​http://jsfiddle.net/FranPregernik/ZVMeq/15/

[sindresorhus]

#11169 is a duplicate of this ticket.

[coopersemantics]

​https://github.com/jquery/jquery/pull/924

[dcooper]

Fix #9960, allow manipulation for parent document nodes. Close gh-924.

Changeset: 78c1560065e664213ac0cbea7518d442a58b0018