#9384 closed feature (wontfix)
jQuery.fx.interval should be replaced by an 'animation-tick' throttling feature.
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | low | Milestone: | None |
| Component: | effects | Version: | 1.6.1 |
| Keywords: | 1.9-discuss | Cc: | |
| Blocked by: | Blocking: |
Description (last modified by )
jQuery.fx.interval should be replaced by an 'animation-tick' throttling feature. Why removing fx.interval?
- reducing fx.interval fails at producing noticeably smoother animations (browser vendors even agreed on a 16.666 value to aim for 60fps)
- fx.interval is useless in browsers supporting requestAnimationFrame
- developers struggle at updating the interval value while their animation is running (example: http://forum.jquery.com/topic/jquery-fx-interval-controlled-by-ui-slider-help )
Why throttling animation ticks instead?
- because it serves a similar purpose (saving CPU cycles when animations do not need to run at 60fps)
- because it can solves all of the above problems
- because the implementation adds only 1 line of code: https://github.com/jquery/jquery/pull/334/files
Change History (25)
comment:1 Changed 7 years ago by
| Keywords: | 1.7-discuss added |
|---|
comment:5 Changed 7 years ago by
| Component: | unfiled → effects |
|---|---|
| Description: | modified (diff) |
| Priority: | undecided → low |
| Status: | new → open |
comment:6 Changed 7 years ago by
+0, That commit has more than one line of code. Also, it changes the documented jQuery.fx.interval behavior. What docs changes do we need on this?
comment:7 Changed 7 years ago by
| Description: | modified (diff) |
|---|
+1, I think this is fine. Good to get consistency.
comment:10 Changed 7 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | 1.next → 1.7 |
| Owner: | set to lrbabe |
| Status: | open → assigned |
comment:12 Changed 7 years ago by
| Keywords: | 1.8-discuss added; 1.7-discuss removed |
|---|---|
| Milestone: | 1.7 → 1.8 |
Pushed to 1.8 since requestAnimationFrame was removed in 1.6.3 and it should be addressed as part of a larger animation reorganization.
comment:15 Changed 7 years ago by
| Description: | modified (diff) |
|---|
+0, Definitely part of a bigger rethink, so I'll defer to gnarf.
comment:18 Changed 7 years ago by
| Description: | modified (diff) |
|---|
+1, I tend to trust gnarf on these things
comment:19 Changed 6 years ago by
| Owner: | changed from lrbabe to gnarf |
|---|
comment:20 Changed 6 years ago by
| Keywords: | 1.9-discuss added; 1.8-discuss removed |
|---|---|
| Milestone: | 1.8 → 1.9 |
It is time to talk about rAF again?
comment:21 Changed 6 years ago by
| Type: | enhancement → feature |
|---|
Bulk change from enhancement to feature.
comment:23 Changed 6 years ago by
| Owner: | gnarf deleted |
|---|---|
| Status: | assigned → open |
I would really like to see this as one of those "interchangable" points, that we could actually release a plugin to use a different "timer loop" -- The setTimeout() and interval right now are like the "default" and also, no matter what we end up doing, they are the least amount of code. I'm going to pull myself off of this one and suggest that we think about making the "tick throttling" a pluginable feature.
comment:24 Changed 6 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | open → closed |
Closing this in favor of #12803
comment:25 Changed 6 years ago by
| Milestone: | 1.9 → None |
|---|
Nominating ticket for 1.7 discussion.