Bug Tracker

Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#9384 closed feature (wontfix)

jQuery.fx.interval should be replaced by an 'animation-tick' throttling feature.

Reported by: louisremi@… Owned by:
Priority: low Milestone: None
Component: effects Version: 1.6.1
Keywords: 1.9-discuss Cc:
Blocked by: Blocking:

Description (last modified by Rick Waldron)

jQuery.fx.interval should be replaced by an 'animation-tick' throttling feature. Why removing fx.interval?

Why throttling animation ticks instead?

  • because it serves a similar purpose (saving CPU cycles when animations do not need to run at 60fps)
  • because it can solves all of the above problems
  • because the implementation adds only 1 line of code: https://github.com/jquery/jquery/pull/334/files

Change History (25)

comment:1 Changed 7 years ago by john

Keywords: 1.7-discuss added

Nominating ticket for 1.7 discussion.

comment:2 Changed 7 years ago by Rick Waldron

Description: modified (diff)

+0,

comment:3 Changed 7 years ago by jaubourg

+1, Agreed

comment:4 Changed 7 years ago by timmywil

+1, do it :)

comment:5 Changed 7 years ago by timmywil

Component: unfiledeffects
Description: modified (diff)
Priority: undecidedlow
Status: newopen

comment:6 Changed 7 years ago by dmethvin

+0, That commit has more than one line of code. Also, it changes the documented jQuery.fx.interval behavior. What docs changes do we need on this?

comment:7 Changed 7 years ago by john

Description: modified (diff)

+1, I think this is fine. Good to get consistency.

comment:8 Changed 7 years ago by ajpiano

Description: modified (diff)

+1

comment:9 Changed 7 years ago by scottgonzalez

Description: modified (diff)

+0

comment:10 Changed 7 years ago by lrbabe

Description: modified (diff)
Milestone: 1.next1.7
Owner: set to lrbabe
Status: openassigned

comment:11 Changed 6 years ago by timmywil

pull request from lrbabe

comment:12 Changed 6 years ago by dmethvin

Keywords: 1.8-discuss added; 1.7-discuss removed
Milestone: 1.71.8

Pushed to 1.8 since requestAnimationFrame was removed in 1.6.3 and it should be addressed as part of a larger animation reorganization.

comment:13 Changed 6 years ago by mikesherov

Description: modified (diff)

+1

comment:14 Changed 6 years ago by jaubourg

+0, Part of a bigger animation rewrite

comment:15 Changed 6 years ago by dmethvin

Description: modified (diff)

+0, Definitely part of a bigger rethink, so I'll defer to gnarf.

comment:16 Changed 6 years ago by jzaefferer

Description: modified (diff)

+1, if raf is coming back

comment:17 Changed 6 years ago by timmywil

+1, Makes sense if raf comes back

comment:18 Changed 6 years ago by Rick Waldron

Description: modified (diff)

+1, I tend to trust gnarf on these things

comment:19 Changed 6 years ago by gnarf

Owner: changed from lrbabe to gnarf

comment:20 Changed 5 years ago by dmethvin

Keywords: 1.9-discuss added; 1.8-discuss removed
Milestone: 1.81.9

It is time to talk about rAF again?

comment:21 Changed 5 years ago by dmethvin

Type: enhancementfeature

Bulk change from enhancement to feature.

comment:22 Changed 5 years ago by mikesherov

+1, still plus one

comment:23 Changed 5 years ago by gnarf

Owner: gnarf deleted
Status: assignedopen

I would really like to see this as one of those "interchangable" points, that we could actually release a plugin to use a different "timer loop" -- The setTimeout() and interval right now are like the "default" and also, no matter what we end up doing, they are the least amount of code. I'm going to pull myself off of this one and suggest that we think about making the "tick throttling" a pluginable feature.

comment:24 Changed 5 years ago by mikesherov

Resolution: wontfix
Status: openclosed

Closing this in favor of #12803

comment:25 Changed 5 years ago by dmethvin

Milestone: 1.9None
Note: See TracTickets for help on using tickets.