Bug Tracker

Opened 12 years ago

Closed 12 years ago

#8814 closed enhancement (fixed)

Unnecessary code in inArray

Reported by: Timmy Willison Owned by: Timmy Willison
Priority: low Milestone: 1.next
Component: core Version: 1.5.2
Keywords: Cc:
Blocked by: Blocking:


I was looking through core.js and noticed the redefinition of inArray using indexOf if it exists. Since this overrides the function, we don't need to check for indexOf in the fallback inArray definition. pull request

Change History (3)

comment:1 Changed 12 years ago by Timmy Willison

Component: unfiledcore
Owner: set to Timmy Willison
Priority: undecidedlow
Status: newassigned

comment:2 Changed 12 years ago by Rick Waldron

Building on timmywil's commit, I reduced the overhead further, with negligible performance loss:



Version 0, edited 12 years ago by Rick Waldron (next)

comment:3 Changed 12 years ago by Rick Waldron

Resolution: fixed
Status: assignedclosed

Fixes #8814. Clean up inArray.

Changeset: 8c40c00fac2f30fa0804ae8097642636f9718ddd

Note: See TracTickets for help on using tickets.