Side navigation
#8814 closed enhancement (fixed)
Opened April 08, 2011 12:55AM UTC
Closed April 10, 2011 06:32PM UTC
Unnecessary code in inArray
| Reported by: | timmywil | Owned by: | timmywil |
|---|---|---|---|
| Priority: | low | Milestone: | 1.next |
| Component: | core | Version: | 1.5.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
I was looking through core.js and noticed the redefinition of inArray using indexOf if it exists. Since this overrides the function, we don't need to check for indexOf in the fallback inArray definition.
Attachments (0)
Change History (3)
Changed April 08, 2011 12:56AM UTC by comment:1
| component: | unfiled → core |
|---|---|
| owner: | → timmywil |
| priority: | undecided → low |
| status: | new → assigned |
Changed April 08, 2011 01:51AM UTC by comment:2
| _comment0: | Building on timmywil's commit, I reduced the overhead further, with negligible performance loss: \ \ https://github.com/jquery/jquery/pull/308 \ \ http://jsperf.com/init-time-vs-on-call \ \ → 1302228689633263 |
|---|
Building on timmywil's commit, I reduced the codesize further, with negligible performance loss: