Bug Tracker

Changes between Initial Version and Version 1 of Ticket #7853, comment 5


Ignore:
Timestamp:
Dec 28, 2010, 11:04:29 AM (11 years ago)
Author:
T.J. Crowder
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7853, comment 5

    initial v1  
    11@Dave: No worries, and thanks.
    22
    3 Yeah, the fix for `add` is easy, but I wonder if `.context` is being used elsewhere where it shouldn't be as well. I mean, obviously `$('#first')` and `$(document.getElementById('first'))` can't mean //exactly// the same thing, not if `live` is going to work with its current API. But a bit of an audit may be necessary to check that `.context` isn't being used elsewhere when it shouldn't be. I don't know the code well enough to do that. I see `.context` used in `closest`, for instance, but I don't know whether that use is correct or incorrect...
     3Yeah, the fix for `add` is easy, but I wonder if `.context` is being used elsewhere where it shouldn't be as well. I mean, obviously `$('#first')` and `$(document.getElementById('first'))` can't mean //exactly// the same thing, not if `live` is going to work with its current API. But a bit of an audit may be necessary to check that `.context` isn't being used elsewhere when it shouldn't be. I don't know the code well enough to do that. I see `.context` used in `closest` and a couple of other places, for instance, but I don't know whether that use is correct or incorrect...