Bug Tracker

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#6997 closed bug (fixed)

before and after do not clone events data properly

Reported by: israelrios Owned by: john
Priority: blocker Milestone: 1.5
Component: manipulation Version: 1.4.2
Keywords: before clone Cc:
Blocked by: Blocking:

Description

The documentation says insertBefore() and before() behavior is similar but with params and object inverted. But, when clones are made of the inserted element this isn't true. The insertBefore() clone the element's events and data, but before() does not.

Change History (12)

comment:1 Changed 10 years ago by snover

Milestone: 1.4.2
Owner: set to israelrios
Priority: undecided
Status: newpending

Please provide a test case demonstrating this issue.

comment:2 Changed 10 years ago by israelrios

Status: pendingnew

I created a test case:

http://jsfiddle.net/AcepV/4/

comment:3 Changed 10 years ago by snover

Milestone: 1.next
Priority: undecidedblocker
Status: newopen

comment:4 Changed 10 years ago by snover

Summary: insertBefore() and before() clone behavior differbefore and after do not clone events data properly

comment:5 Changed 10 years ago by snover

Milestone: 1.4.41.4.5

Retargeting due to severity of 1.4.3 regressions.

comment:6 Changed 10 years ago by snover

Milestone: 1.4.51.4.4

Retargeting for 1.4.4 as per John’s request.

comment:7 Changed 10 years ago by john

Owner: changed from israelrios to john
Status: openassigned

comment:8 Changed 10 years ago by snover

Milestone: 1.4.41.4.5

Retargeting to next minor release.

comment:9 Changed 10 years ago by snover

Resolution: duplicate
Status: assignedclosed

comment:10 Changed 10 years ago by snover

Duplicate of #5566.

comment:11 Changed 10 years ago by Colin Snover

Resolution: duplicatefixed

Merge branch 'bug5566' into csnover-bug5566. Fixes #4386, #5566, #6997.

Conflicts:

src/manipulation.js test/unit/manipulation.js

Changeset: 4fae75d575b20d887e4a273c7991c55f8821a62c

comment:7 Changed 10 years ago by jitter

Milestone: 1.4.51.5

Move fixed tickets to appropriate milestone

Note: See TracTickets for help on using tickets.