.live('click',handler) should not fire on disabled button in IE

[yoursunny]

Take the following snippet:

<div id="a"> <input type="button" disabled="disabled" id="b1" value="button1"> </div>

$(':button','#a').live('click',function(){ });

The live click event does not fire in Firefox 3.6, but fires in IE8 on Win7. Since the button is disabled, I think the correct implementation should not fire live click event on #b1.

[yoursunny]

reproduce code

[snover]

​live test case

[snover]

Retargeting due to severity of regressions in 1.4.3.

[snover]

Retargeting for 1.4.4 as per John’s request.

[anonymous]

Submitted pull request to disable events on disabled items: ​http://github.com/jquery/jquery/pull/76

[danheberden]

Heh, guess it helps to log in before doing that :p Pull req: ​http://github.com/jquery/jquery/pull/76

[snover]

Retargeting to next minor release.

[dmethvin]

​https://github.com/jquery/jquery/commit/bd474799bf95f4ecdc47a7577750eaf69e2236d4

[danheberden]

That commit was backed out - I will provide a new one.

[danheberden]

​https://github.com/jquery/jquery/pull/108

[john]

Landed.

[jitter]

Move fixed tickets to appropriate milestone

[marksteward@…]

Is this correct? It seems to me the fix should be to check currentTarget, not target.

Also, it's not limited to IE - it can be reproduced on Chrome 9.0.597.45. See ​http://forum.jquery.com/topic/live-inconsistency-with-disabled-buttons.

[danheberden]

​http://jsfiddle.net/danheberden/ZaU4E/ - take it for a spin :)

[ms7821]

danheberden: thanks. I think this might really be a separate bug, which is half fixed by your commit.

It's possible to receive events for a disabled <button> element as well as <input type="button">:

​http://jsfiddle.net/Fz2F3/ (jQuery 1.4.4) ​http://jsfiddle.net/Fz2F3/1/ (jQuery 1.5)

IE7 fires click for all of them, passing the button as the target and currentTarget. Chrome fires only for the <button> with a child element, passing that as the target. However, currentTarget is set to the button, so changing target.disabled to currentTarget.disabled should extend the fix to include Chrome.

I didn't realise 1.5 had already been released, so I'll open a new ticket specifically for buttons on Chrome.

Mark

[danheberden]

Well in the end it's the same root issue, i'll go a head and re-open this one. Thanks for your work!

[ms7821]

Ahh, do you want me to delete ​http://bugs.jquery.com/ticket/8165?

[danheberden]

#8165 is a duplicate of this ticket.

[danheberden]

Marked as dup - that'll link them together :)

[danheberden]

actually, just might got it fixed

[danheberden]

DaveMethvin pummeled me until i saw a way to do it - all better in ​https://github.com/jquery/jquery/pull/237

[john]

Landed.

[ms7821]

Awesome to see, thanks danheberden!