Bug Tracker

Opened 7 years ago

Closed 6 years ago

Last modified 5 years ago

#6743 closed bug (fixed)

map enctype to encoding, depending on browser

Reported by: Ollie2893 Owned by: timmywil
Priority: low Milestone: 1.7
Component: attributes Version: 1.5.2
Keywords: attr enctype encoding Cc: SlexAxton
Blocked by: Blocking:

Description

I cannot be the first person to raise this request but I cannot find a ticket anywhere. In the .attr(), please harmonize the handling of "enctype" across browsers. For IE this means that jQuery should map "enctype" to "encoding". I figured this out at the end of a frustrating multi-hour debugging session. I really rely on jQuery to take care of these irritating small idiosyncrasies between browsers (lest my code be polluted by browser-specific hacks). Thank you.

Change History (10)

comment:1 Changed 7 years ago by dmethvin

Component: unfiledattributes

comment:2 Changed 6 years ago by SlexAxton

Cc: SlexAxton added
Keywords: attr enctype encoding added
Priority: low
Status: newopen
Type: enhancementbug

This seems legit. Prototype does this translation as well. I think it could be done with a pretty simple feature test.

I created a possible solution in a jsfiddle. http://jsfiddle.net/SlexAxton/59znU/

I'll pull a patch sometime soon, unless someone thinks it's a terrible idea?

I usually err on the side of 'this is an enhancement' - but I'd say jQuery should be handling a cross-browser issue like this, so I'll land this as a bug fix (just not the regression kind).

Related Prototype ticket: https://prototype.lighthouseapp.com/projects/8886/tickets/658-writeattribute-doesnt-work-properly-with-enctypeencoding

comment:3 Changed 6 years ago by SlexAxton

Milestone: 1.4.31.5

Moving to appropriate release

comment:4 Changed 6 years ago by jitter

#8186 is a duplicate of this ticket.

comment:5 Changed 6 years ago by jitter

Milestone: 1.5.1
Owner: set to jitter
Status: openassigned
Version: 1.4.21.5

comment:6 Changed 6 years ago by timmywil

Any updates on this one? Did we decide we want to add the fix?

comment:7 Changed 6 years ago by timmywil

Milestone: 1.5.11.next
Version: 1.51.5.2

comment:8 Changed 6 years ago by john

Owner: changed from jitter to timmywil

Yeah, we should tackle this - as discussed in the bug triage meeting.

comment:9 Changed 6 years ago by timmywil

Milestone: 1.next1.7

comment:10 Changed 6 years ago by timmywil

Resolution: fixed
Status: assignedclosed

Support setting both the enctype attribute and property (encoding in IE6/7). Fixes #6743.

Changeset: c51b29477e2884fc28cfe4de5b64308177678262

Note: See TracTickets for help on using tickets.