#6319 closed bug (fixed)
Regression: stopPropagation inside change handlers in IE is incorrectly applied to keydown event
| Reported by: | mikecapp | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.7 |
| Component: | event | Version: | 1.4.3 |
| Keywords: | change keydown IE | Cc: | |
| Blocked by: | Blocking: |
Description
On switching from 1.3.2 to 1.4.2, some of our document-level ENTER keydown handlers stopped working when triggered from a just-modified textbox.
STEPS TO REPRODUCE:
- Load attached reduction
- Click on page background, then in textbox
- Type something
- Press ENTER
- Press ENTER again
EXPECTED RESULTS:
The green ENTER indicator bar should flash for each press
ACYUAL RESULTS:
The green ENTER bar does NOT flash for the first press, although the red CHANGE bar does. The green bar DOES flash for the second press.
FURTHER DETAILS:
The reduction binds a handler to the change event on the input, which calls stopPropagation().
Reduction tested on Win2003/IE7; also reported on XP/IE6.
Not reproducible on non-IE browsers.
Reproducible with current nightly.
HYPOTHESIS: (a.k.a. "wild speculation")
1.3.2/IE didn't raise a change event on Enter; this could be a problem since the Enter will often be triggering form submission.
1.4.2 fixes this by detecting Enter keydowns and raising the change manually.
However, it's not cloning (or dummying up) the event object passed to the change handler, so that stopPropagation() on the change event is also stopping propagation of the keydown event.
Attachments (2)
Change History (15)
Changed 13 years ago by
| Attachment: | jq142_enter.html added |
|---|
Changed 13 years ago by
| Attachment: | jquery-ie-onchange.zip added |
|---|
comment:1 Changed 13 years ago by
I am having almost the same issue. All other browsers work fine. IE7 does not work. In my case I have to change the text field twice for the onchange event to fire. Does not matter if it is focussed with the mouse or keyboard. I am using tab to move between fields. The enter key can be used to active the onchange in other browsers but not in IE 7.
comment:2 Changed 13 years ago by
Switched from 1.4.1 to 1.4.2 and the problem still existed for a while then went away. Now I cannot recreate. was probably a caching issue. Sorry.
comment:4 Changed 12 years ago by
| Summary: | Regression: change fixup interfering with keydown in IE → Regression: stopPropagation inside change handlers in IE is incorrectly applied to keydown event |
|---|
comment:5 Changed 12 years ago by
| Milestone: | 1.4.3 → 1.4.4 |
|---|---|
| Priority: | undecided → high |
| Status: | new → open |
| Version: | 1.4.2 → 1.4.3 |
comment:6 Changed 12 years ago by
| Milestone: | 1.4.4 → 1.5 |
|---|
comment:7 Changed 12 years ago by
| Owner: | set to dmethvin |
|---|---|
| Status: | open → assigned |
Test case (IE): http://jsfiddle.net/dmethvin/687tE/3/
comment:9 Changed 12 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Whoops, no it wasn't, I misinterpreted the test case.
comment:10 Changed 12 years ago by
| Status: | reopened → open |
|---|
comment:11 Changed 12 years ago by
| Milestone: | → 1.next |
|---|
comment:12 Changed 12 years ago by
| Milestone: | 1.next → 1.7 |
|---|
This seems to be fixed in my 1.7 branch; I'll retest once it lands in master.
comment:13 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
Rewrite IE special change/submit to make it faster/shorter. Fixes #6319.
Changeset: df6e0d508efd3aa2e242e61d810d22d3491e221c
Reduction