Opened 10 years ago
Closed 10 years ago
#5910 closed bug (fixed)
In 1.4, show/hide methods call animate() when speed is false or empty string
| Reported by: | kswedberg | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.4.1 |
| Component: | effects | Version: | 1.4 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
This isn't necessarily wrong, but it's different from previous versions, so I changed the conditional from:
if ( speed != null )
to:
if ( speed speed === 0 )
I committed the change to my fork on Github: http://github.com/kswedberg/jquery/commit/e708de615723fbff3d121be00c2e4da60fcc72bd
And committed some tests: http://github.com/kswedberg/jquery/commit/a67e074225da785670a170084fbbb490a6915f1e
Change History (1)
comment:1 Changed 10 years ago by
| Component: | unfilled → fx |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Landed. http://github.com/jquery/jquery/commit/21441b1cbc7a205e621b8c94a21eff102380ca03 http://github.com/jquery/jquery/commit/a63754aa4e4e430007208d6b5cb76f9ca8c279f5