Side navigation
#5803 closed enhancement (fixed)
Opened January 14, 2010 03:25PM UTC
Closed January 09, 2011 08:50PM UTC
Last modified March 14, 2012 12:12AM UTC
Set JSONP dataType is jsonpCallback is used
| Reported by: | yehuda | Owned by: | rwaldron |
|---|---|---|---|
| Priority: | low | Milestone: | 1.5 |
| Component: | ajax | Version: | 1.4 |
| Keywords: | ajaxrewrite | Cc: | |
| Blocked by: | Blocking: |
Description
If the user uses the jsonpCallback setting, we should automatically set the dataType to "jsonp".
Attachments (0)
Change History (12)
Changed June 13, 2010 11:57PM UTC by comment:1
| component: | unfiled → ajax |
|---|
Changed October 22, 2010 10:50PM UTC by comment:2
| milestone: | 1.4.1 → 1.5 |
|---|---|
| owner: | → rwaldron |
| priority: | major → low |
| status: | new → assigned |
| type: | bug → enhancement |
Changed October 22, 2010 10:59PM UTC by comment:3
Changed October 22, 2010 11:07PM UTC by comment:4
| milestone: | 1.5 → 1.4.5 |
|---|
1.4.5 loosely speaking...
Changed October 23, 2010 09:37AM UTC by comment:5
Does your change mean that if jsonpCallback is set through $.ajaxSetup() then all requests will be converted to jsonp? It could be useful to set a default callback but have it still only apply to requests specifically set to jsonp. I suggest changing the test to:
if ( origSettings.jsonpCallback ) { ... }
Changed October 25, 2010 08:14PM UTC by comment:6
| milestone: | 1.4.5 → 1.4.4 |
|---|---|
| resolution: | → fixed |
| status: | assigned → closed |
Changed October 26, 2010 01:04AM UTC by comment:7
| resolution: | fixed |
|---|---|
| status: | closed → reopened |
I backed out that patch due to possible problems with the implementation.
Changed October 26, 2010 01:35AM UTC by comment:8
| milestone: | 1.4.4 |
|---|---|
| status: | reopened → assigned |
retargetting to blank and assigning to me.
Changed October 26, 2010 01:08PM UTC by comment:9
| milestone: | → 1.4.5 |
|---|
Changed December 27, 2010 10:37PM UTC by comment:10
| keywords: | → ajaxrewrite |
|---|
Changed January 09, 2011 08:50PM UTC by comment:11
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Fixes #5803. Reworked jsonp prefilter so that it sets the dataType as jsonp and recognizes requests with originalSettings having jsonp or jsonpCallback to be jsonp. Moved default jsonp option value into ajaxSettings. Attached the transport to "jsonp" which avoids unnecessary testing. Transport factory sets dataType back to json for proper data conversion.
Changeset: 62a1a1a8fa64f92f429a3f5b8ed2e0d1f6fc3d6c
Changed January 14, 2011 10:20PM UTC by comment:12
| milestone: | 1.4.5 → 1.5 |
|---|
Move fixed tickets to appropriate milestone