#5803 closed enhancement (fixed)
Set JSONP dataType is jsonpCallback is used
| Reported by: | yehuda | Owned by: | Rick Waldron |
|---|---|---|---|
| Priority: | low | Milestone: | 1.5 |
| Component: | ajax | Version: | 1.4 |
| Keywords: | ajaxrewrite | Cc: | |
| Blocked by: | Blocking: |
Description
If the user uses the jsonpCallback setting, we should automatically set the dataType to "jsonp".
Change History (12)
comment:1 Changed 12 years ago by
| Component: | unfiled → ajax |
|---|
comment:2 Changed 12 years ago by
| Milestone: | 1.4.1 → 1.5 |
|---|---|
| Owner: | set to Rick Waldron |
| Priority: | major → low |
| Status: | new → assigned |
| Type: | bug → enhancement |
comment:3 Changed 12 years ago by
comment:5 Changed 12 years ago by
Does your change mean that if jsonpCallback is set through $.ajaxSetup() then all requests will be converted to jsonp? It could be useful to set a default callback but have it still only apply to requests specifically set to jsonp. I suggest changing the test to:
if ( origSettings.jsonpCallback ) { ... }
comment:6 Changed 12 years ago by
| Milestone: | 1.4.5 → 1.4.4 |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
comment:7 Changed 12 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
I backed out that patch due to possible problems with the implementation.
comment:8 Changed 12 years ago by
| Milestone: | 1.4.4 |
|---|---|
| Status: | reopened → assigned |
retargetting to blank and assigning to me.
comment:9 Changed 12 years ago by
| Milestone: | → 1.4.5 |
|---|
comment:10 Changed 11 years ago by
| Keywords: | ajaxrewrite added |
|---|
comment:11 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixes #5803. Reworked jsonp prefilter so that it sets the dataType as jsonp and recognizes requests with originalSettings having jsonp or jsonpCallback to be jsonp. Moved default jsonp option value into ajaxSettings. Attached the transport to "jsonp" which avoids unnecessary testing. Transport factory sets dataType back to json for proper data conversion.
Changeset: 62a1a1a8fa64f92f429a3f5b8ed2e0d1f6fc3d6c
comment:12 Changed 11 years ago by
| Milestone: | 1.4.5 → 1.5 |
|---|
Move fixed tickets to appropriate milestone
http://github.com/rwldrn/jquery/commit/89850e9bea6c50f916d0e42fa713b59102203a9c