Bug Tracker

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#462 closed bug (fixed)

var are missing in plugins/interface/iutil.js + patch + test

Reported by: toggg Owned by: stefan
Priority: minor Milestone: 1.1a
Component: interface Version: 1.1a
Keywords: Cc:
Blocked by: Blocking:

Description

I noticed several variables which should be local but not declared as such using "var".

It only *may* become a problem.

Modified iutil.js and patch for it as by [503] follow.

As, I'm unsure and it is a necessity, I join some draft, not achieved, test.

I look forward to complete it with some ok().

Not sure about the getClient() thing...

Also, there's nothing for getPointer(), traverseDOM() and purgeEvents() as they are not directly feasable with the current simple test scheme. Same for the second parameter "toInteger" when it applies. I'll prepare something more complete.

Attachments (1)

iutil.js.patch (6.4 KB) - added by toggg 13 years ago.
interface/iutil.js patch for #462

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by toggg

Attachment: iutil.js.patch added

interface/iutil.js patch for #462

comment:3 Changed 13 years ago by toggg

I refactored the above test.

Case the test fails, a button should show to display the diffs.

Expected values are FF based. So far we can see , only IE fails.

comment:4 Changed 13 years ago by anonymous

ie5.5: 5 fail (1-5)
ie6.0: 3 fail (1,2,5)
ie5.0: doesn't run (haven't investigated)
opera9.00: 3 fail (1,2,5)
konq3.55: pass
ff2.0: pass

note: ies running through wine

comment:5 Changed 13 years ago by stefan

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.