Selectors using style attribute broken

[remysharp]

Demonstrations:

​http://remysharp.com/demo/selector-issue.html

Using the style attribute in the selector either returns the wrong number of results or throws exception.

Tested in FF2 and Safari (test above makes use of console.log).

Example selectors broken:

$(div[style]); returns total number of elements regardless of result

$(div[style^{="color"]); throws exception}

[remysharp]

I think I've found a/the fix, but I've only been able to test on a Mac so far, Opera 9*, Safari 3, FF2 - not IE testing as yet, all browsers give the right result.

• Opera gives almost the right results. It certainly counts the attribute correctly, but if you're pulling the style from <div style="color: red;" /> it translates it to "color: #ff0000" (sans semi-colon) which means it doesn't match some of the selectors - however colour aside, it fixes Opera.

File: src/selector.js rev: 5696

Change line 339 from (note intentional spaces in OR to prevent formatting):

if ( z == null | | /href|src|selected/.test(m[2]) )

To:

if ( z == null | | /style|href|src|selected/.test(m[2]) )

Diff: ​http://codedumper.com/ocopo#9-10 (I couldn't paste the diff properly)

[flesler]

Will try to check this asap.

[flesler]

Could you recheck with 1.2.6 ?

[remysharp]

Sorry, I thought I sent this check back - no it doesn't work with latest 1.2.6:

​http://remysharp.com/demo/selector-issue.html

[flesler]

Fixed at [5795].

This made me realize of a possible optimization: #3194.

[sandy]

Can you check in version 1.6.2. It does seem to work in this version.

[sandy]

oops! sorry what i meant was It doesn't seem to work in this version.

[Rick Waldron]

@sandy can you provide a complete reduced test case on jsFiddle to help us assess your ticket!

Additionally, be sure to test against the jQuery Edge version to ensure the issue still exists. To get you started, use this boilerplate: ​http://jsfiddle.net/FrKyN/ Open the link and click to "Fork" (in the top menu) to get started.